You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/20 14:42:39 UTC

[GitHub] [nifi-minifi-cpp] neuralfraud opened a new pull request #843: Update WindowsEventLog.cpp - NO JIRA - Hour math bug 

neuralfraud opened a new pull request #843:
URL: https://github.com/apache/nifi-minifi-cpp/pull/843


   Line 81 is incorrect, results in an hour containing "00:00:00 PM"
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] neuralfraud commented on pull request #843: Update WindowsEventLog.cpp - NO JIRA - Hour math bug

Posted by GitBox <gi...@apache.org>.
neuralfraud commented on pull request #843:
URL: https://github.com/apache/nifi-minifi-cpp/pull/843#issuecomment-661128754


   @fgerlits Thanks but also missed something. The SYSTEMTIME struct contains the hour as 0..23 - Thus "00" can still appear in the timestamp as 00:00:00 AM. See second commit. This should fully resolve the issue. Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #843: Update WindowsEventLog.cpp - NO JIRA - Hour math bug

Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #843:
URL: https://github.com/apache/nifi-minifi-cpp/pull/843


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #843: Update WindowsEventLog.cpp - NO JIRA - Hour math bug

Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #843:
URL: https://github.com/apache/nifi-minifi-cpp/pull/843#issuecomment-662416065


   You can subscribe to the list by sending an email to dev-subscribe@nifi.apache.org.
   
   https://nifi.apache.org/mailing_lists.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org