You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org> on 2020/03/13 01:24:22 UTC
[kudu-CR] [KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0)
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15425
Change subject: [KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0)
......................................................................
[KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0)
"new Date" creates different dates depending on timezone. That causes
tests to fail. In order to avoid it, "new Date" is replaced with
DateUtil.epochDaysToSqlDate(0) which internally calls LocalDate
which is timezone irrespective.
Change-Id: Ic381bac8c68499445b6f00a1a76881dac513aede
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
4 files changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15425/1
--
To view, visit http://gerrit.cloudera.org:8080/15425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic381bac8c68499445b6f00a1a76881dac513aede
Gerrit-Change-Number: 15425
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0)
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15425 )
Change subject: [KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0)
......................................................................
Patch Set 1: Verified+1 Code-Review+2
I verified all the test pass locally on my machine.
--
To view, visit http://gerrit.cloudera.org:8080/15425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic381bac8c68499445b6f00a1a76881dac513aede
Gerrit-Change-Number: 15425
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 02:23:52 +0000
Gerrit-HasComments: No
[kudu-CR] [KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0)
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15425 )
Change subject: [KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0)
......................................................................
[KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0)
"new Date" creates different dates depending on timezone. That causes
tests to fail. In order to avoid it, "new Date" is replaced with
DateUtil.epochDaysToSqlDate(0) which internally calls LocalDate
which is timezone irrespective.
Change-Id: Ic381bac8c68499445b6f00a1a76881dac513aede
Reviewed-on: http://gerrit.cloudera.org:8080/15425
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
4 files changed, 12 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic381bac8c68499445b6f00a1a76881dac513aede
Gerrit-Change-Number: 15425
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)