You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 23:38:58 UTC

[GitHub] [airflow] jedcunningham opened a new pull request #20121: Fix log link in gantt view

jedcunningham opened a new pull request #20121:
URL: https://github.com/apache/airflow/pull/20121


   The link to the log in the gantt view modal was a broken link as the execution_date wasn't isoformatted.
   
   Closes #19613


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham merged pull request #20121: Fix log link in gantt view

Posted by GitBox <gi...@apache.org>.

jedcunningham merged pull request #20121:
URL: https://github.com/apache/airflow/pull/20121


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #20121: Fix log link in gantt view

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #20121:
URL: https://github.com/apache/airflow/pull/20121#issuecomment-988554510






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a change in pull request #20121: Fix log link in gantt view

Posted by GitBox <gi...@apache.org>.

uranusjr commented on a change in pull request #20121:
URL: https://github.com/apache/airflow/pull/20121#discussion_r764597161



##########
File path: airflow/www/views.py
##########
@@ -2889,7 +2889,7 @@ def gantt(self, session=None):
             task_dict['end_date'] = task_dict['end_date'] or timezone.utcnow()
             task_dict['extraLinks'] = dag.get_task(ti.task_id).extra_links
             task_dict['try_number'] = try_count
-            task_dict['execution_date'] = dttm
+            task_dict['execution_date'] = dttm.isoformat()

Review comment:
       Sign I really hate this subtle `T` and space difference in Python’s datetime.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org