You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Nicolas Peltier (JIRA)" <ji...@apache.org> on 2018/07/03 21:36:00 UTC
[jira] [Comment Edited] (SLING-7759) add other "patterns" than path
for filters
[ https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531956#comment-16531956 ]
Nicolas Peltier edited comment on SLING-7759 at 7/3/18 9:35 PM:
----------------------------------------------------------------
introduced FilterPredicate in https://github.com/apache/sling-org-apache-sling-engine/pull/3, please review.
Note
* i didn't add filter.prefix, as i'm not sure it makes sense, and it is a complicated beast.
* I finally added paths because it is simple, although i'm not sure it makes sense.
* Hope adding commons-lang3 is ok,
* for selectors, i just added a "OR" simple implementation
was (Author: npeltier):
introduced FilterPredicate in https://github.com/apache/sling-org-apache-sling-engine/pull/3, please review.
Note i didn't add filter.prefix, as i'm not sure it makes sense, and it is a complicated beast. I finally added paths because it is simple, although i'm not sure it makes sense.
Hope adding commons-lang3 is ok
> add other "patterns" than path for filters
> ------------------------------------------
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
> Affects Versions: Engine 2.6.12
> Reporter: Nicolas Peltier
> Assignee: Nicolas Peltier
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}} allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add sling.filter.pattern.path for consistency with what follow) regexp matches current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)