You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "zhl11b (via GitHub)" <gi...@apache.org> on 2025/12/25 08:12:21 UTC

[PR] fix: Populate the protocol version of the original request to the ups… [apisix]

zhl11b opened a new pull request, #12842:
URL: https://github.com/apache/apisix/pull/12842

   ### Description
   
   fix: Populate the protocol version of the original request to the ups…
   If the version is not passed, upstream may use the default version, leading to inconsistent behavior or compatibility issues.
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Populate the protocol version of the original request to the ups… [apisix]

Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming closed pull request #12842: fix: Populate the protocol version of the original request to the ups…
URL: https://github.com/apache/apisix/pull/12842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Populate the protocol version of the original request to the ups… [apisix]

Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on PR #12842:
URL: https://github.com/apache/apisix/pull/12842#issuecomment-4064882353

   Hi @zhl11b, thank you for submitting this!
   
   I have a few concerns with the current state of this PR:
   
   1. **Missing context**: There's no associated issue describing the problem this fixes. Could you share the specific scenario where you encountered this issue?
   
   2. **No test coverage**: The single-line change to `ext-plugin-post-resp.lua` doesn't have any accompanying tests to verify the fix and prevent regression.
   
   3. **Unclear impact**: Without a clear description of the bug and steps to reproduce, it's difficult to validate whether this change is correct and doesn't introduce side effects.
   
   Since this has been inactive for several months, I'm going to close this PR. If you're still experiencing the issue, please:
   1. Open an issue first describing the problem with reproduction steps
   2. Submit a new PR with the fix and test cases that demonstrate the before/after behavior
   
   Thanks for your interest in improving APISIX!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Populate the protocol version of the original request to the ups… [apisix]

Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12842:
URL: https://github.com/apache/apisix/pull/12842#issuecomment-4037970974

   Hi @zhl11b, following up on the previous review comments. Please let us know if you have any updates. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org