You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by danbroudy <no...@github.com> on 2015/05/29 21:50:07 UTC
[jclouds-labs-google] Adding builder to NewInstance, add tests.
(#142)
This PR adds a builder to NewInstance making it possible to add serviceAccounts and scopes to a instance.
This is related to JCLOUDS-906 but does not propagate the changes to the Compute Abstraction.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs-google/pull/142
-- Commit Summary --
* Adding builder to NewInstance, add tests.
-- File Changes --
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/NewInstance.java (87)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Tags.java (4)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiLiveTest.java (29)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiMockTest.java (37)
A google-compute-engine/src/test/resources/instance_insert_full.json (47)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/142.patch
https://github.com/jclouds/jclouds-labs-google/pull/142.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/142
Re: [jclouds-labs-google] JCLOUDS-906: NewInstance builder and
Service Accounts to GoogleComputeEngineTemplateOptions (#142)
Posted by Ignasi Barrera <no...@github.com>.
Squashed and pushed to master as [0e3263e0](http://git-wip-us.apache.org/repos/asf/jclouds-labs-google/commit/0e3263e0). Thanks @danbroudy!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/142#issuecomment-108134277
Re: [jclouds-labs-google] JCLOUDS-906: NewInstance builder and
Service Accounts to GoogleComputeEngineTemplateOptions (#142)
Posted by Ignasi Barrera <no...@github.com>.
Closed #142.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/142#event-320612569