You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "julianhyde (via GitHub)" <gi...@apache.org> on 2023/04/21 01:34:39 UTC

[GitHub] [calcite] julianhyde commented on pull request #3140: [CALCITE-5614] Serialize / deserialize Sarg

julianhyde commented on PR #3140:
URL: https://github.com/apache/calcite/pull/3140#issuecomment-1517134261

   There are autostyle violations. Can you run `./gradlew clean build -x rat` and fix the errors shown?
   
   I am uneasy about using the `JsonCreator` annotation, because it sprinkles Jackson dependencies all over the code. I believe you can achieve the same effect using `ObjectMapper`. I am going to try some experiments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org