You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by Nakomis <gi...@git.apache.org> on 2014/07/01 13:13:19 UTC
[GitHub] incubator-brooklyn pull request: Cluster initialization refactorin...
GitHub user Nakomis opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/36
Cluster initialization refactoring
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Nakomis/incubator-brooklyn cluster-initialization-refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit f9576bac4c82b29f5f0812b4f0d44393869a582e
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-06-20T09:34:39Z
Copied in @ZaidM's work from https://github.com/ZaidM/brooklyn/tree/couchbase-sync-gateway1
commit b06812074916216634b72791718cc6ab7b9951b3
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-06-25T15:44:11Z
Fixed bucket creation
commit f2ddc95c0c0db24bffbefe770a5e828e0793dd02
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-01T09:43:16Z
Fixed CouchbaseSyncGateway live tests
commit 1c2fed431271eccd32408d7297623b527210becc
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-01T11:12:54Z
Added refactoring comments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Cluster initialization refactorin...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/36#issuecomment-48453045
Do you want to add the commit "Added refactoring comments" to PR #25, and close this PR (as it is otherwise the same). My review comments in #25 are partly covered by the addition of these comments describing future refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Cluster initialization refactorin...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/36#issuecomment-48452823
See comments in #25, as this PR includes those commits. Let's merge #25 first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Cluster initialization refactorin...
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/36#issuecomment-54077202
This was originally intended to build on the work that was done for #25, and refactor out some of the Time.sleep() calls, and is now essentially a refactoring comment. I'll rebase away the other commits so it will just add the refactoring comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Cluster initialization refactorin...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/36#issuecomment-53937933
@Nakomis what is relationship of this to similar (conflicting?) work in #25 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Cluster initialization refactorin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---