You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/19 13:35:47 UTC
[GitHub] [solr] dweiss opened a new pull request #34: Cleanup of lazy props around solr ref guide
dweiss opened a new pull request #34:
URL: https://github.com/apache/solr/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] dweiss commented on a change in pull request #34: Cleanup of lazy props around solr ref guide
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #34:
URL: https://github.com/apache/solr/pull/34#discussion_r597772911
##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -210,9 +210,6 @@ class RenderJavadocTask extends DefaultTask {
@Input
def offlineLinks = [:]
- @Input
- def luceneDocUrl = "${-> project.luceneDocUrl }"
-
@Input
def solrDocUrl = "${-> project.solrDocUrl }"
Review comment:
Updated the PR, seems to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] uschindler commented on a change in pull request #34: Cleanup of lazy props around solr ref guide
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #34:
URL: https://github.com/apache/solr/pull/34#discussion_r597686153
##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -210,9 +210,6 @@ class RenderJavadocTask extends DefaultTask {
@Input
def offlineLinks = [:]
- @Input
- def luceneDocUrl = "${-> project.luceneDocUrl }"
-
@Input
def solrDocUrl = "${-> project.solrDocUrl }"
Review comment:
I think we should do here the same like in Lucene to allow snapshots without any link (null).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] uschindler commented on pull request #34: Cleanup of lazy props around solr ref guide
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #34:
URL: https://github.com/apache/solr/pull/34#issuecomment-802988941
What's wrong with precommit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] asfgit closed pull request #34: Cleanup of lazy props around solr ref guide
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #34:
URL: https://github.com/apache/solr/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] dweiss commented on a change in pull request #34: Cleanup of lazy props around solr ref guide
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #34:
URL: https://github.com/apache/solr/pull/34#discussion_r597688851
##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -210,9 +210,6 @@ class RenderJavadocTask extends DefaultTask {
@Input
def offlineLinks = [:]
- @Input
- def luceneDocUrl = "${-> project.luceneDocUrl }"
-
@Input
def solrDocUrl = "${-> project.solrDocUrl }"
Review comment:
Yup. I can't do all of it though. I've spent a good two hours cleaning up other cruft. ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] uschindler commented on a change in pull request #34: Cleanup of lazy props around solr ref guide
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #34:
URL: https://github.com/apache/solr/pull/34#discussion_r597783263
##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -210,9 +210,6 @@ class RenderJavadocTask extends DefaultTask {
@Input
def offlineLinks = [:]
- @Input
- def luceneDocUrl = "${-> project.luceneDocUrl }"
-
@Input
def solrDocUrl = "${-> project.solrDocUrl }"
Review comment:
Looks great, 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org