[GitHub] [incubator-pinot] npawar commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #6113:
URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r504983362



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -378,7 +463,12 @@ public void replaceLLSegment(String segmentName, IndexLoadingConfig indexLoading
     try {
       File indexDir = new File(_indexDir, segmentName);
       Schema schema = ZKMetadataProvider.getTableSchema(_propertyStore, _tableNameWithType);
-      addSegment(ImmutableSegmentLoader.load(indexDir, indexLoadingConfig, schema));
+      PartitionUpsertMetadataManager partitionUpsertMetadataManager = null;
+      if (_tableUpsertMetadataManager != null) {
+        int partitionId = new LLCSegmentName(segmentName).getPartitionId();

Review comment:
       as of now I don't see any other way of getting the partition id. Separately, we might want to start changes to put partition id/ sequence number into the segment zk metadata.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org