[jira] [Commented] (TAJO-1506) WorkerConnectionInfo::id field may be not unique, but its uniqueness is assumed throughout codes.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985627#comment-14985627 ] 

ASF GitHub Bot commented on TAJO-1506:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/510


> WorkerConnectionInfo::id field may be not unique, but its uniqueness is assumed throughout codes.
> -------------------------------------------------------------------------------------------------
>
>                 Key: TAJO-1506
>                 URL: https://issues.apache.org/jira/browse/TAJO-1506
>             Project: Tajo
>          Issue Type: Improvement
>          Components: QueryMaster, Worker
>            Reporter: Hyunsik Choi
>            Assignee: Jihun Kang
>         Attachments: TAJO-1506.patch, TAJO-1506_1.patch, TAJO-1506_2.patch, TAJO-1506_3.patch, TAJO-1506_4.patch
>
>
> WorkerConnectionInfo::id is a integer value. It is generated in Worker by a hashCode as follows:
> {code}
> public WorkerConnectionInfo(String host, int peerRpcPort, int pullServerPort, int clientPort,
>                               int queryMasterPort, int httpInfoPort) {
> ...
>     this.queryMasterPort = queryMasterPort;
>     this.httpInfoPort = httpInfoPort;
>     this.id = hashCode();
> {code}
> Fundamentally, it uses hashCode method, so there are possibility to cause duplicate integer value. But, all codes assume its uniqueness. It is a potential problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)