You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/26 02:02:10 UTC

[GitHub] [pulsar] codelipenghui commented on pull request #19019: [improve][doc] Java example explaining code without using lombok

codelipenghui commented on PR #19019:
URL: https://github.com/apache/pulsar/pull/19019#issuecomment-1364808642

   @AlvaroStream 
   
   I noticed you have removed
   
   ```
      @Builder
       @AllArgsConstructor
       @NoArgsConstructor
   ```
   
   From the last comment https://github.com/apache/pulsar/pull/19019#discussion_r1055114376. We don't need to add the constructors if we have the annotation. The Lombok will generate them. 
   
   We should remove https://github.com/apache/pulsar/pull/19019/files#diff-fe3c06d8365d562427069af4376e699002169fdcf1047e836e771ce355756044R130-R134 if we have Lombok annotations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org