You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "kayemkim (via GitHub)" <gi...@apache.org> on 2026/10/16 01:24:15 UTC

[PR] test(validation): give each duplicate relationship its own dict [ossie]

kayemkim opened a new pull request, #592:
URL: https://github.com/apache/ossie/pull/592

   ## Summary
   
   `_with_duplicate_relationships` passes the same dict three times, and since #586 moved the deep copy into `_document()`, `copy.deepcopy` keeps that sharing, so the three duplicates come back as one object. Nothing fails today because the tests only validate the document, but a later test that edits one duplicate would edit all three. Each entry is now built with its own `_relationship()` call, the way the field and metric helpers above it already do. JB pointed this out when reviewing #586.
   
   ## Verification
   
   - `validation/tests/`: 200 passed, and the validation workflow run locally against current main (9531429) on Python 3.11 to 3.14.
   
   ## Related Issues
   
   Follow-up to #586.
   
   ## Checklist
   
   ### Tests
   - [x] All existing tests pass (`pytest` / CI green)
   - [x] New functionality is covered by tests (no new functionality)
   
   ### Compliance
   - [x] ASF license headers are present on all new source files (no new files)
   - [x] No third-party dependencies are added without PMC/IPMC approval
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(validation): give each duplicate relationship its own dict [ossie]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #592:
URL: https://github.com/apache/ossie/pull/592


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org