You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/13 20:24:20 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8557:
[WIP][dashboard scoped filter] part 1: scope selector modal
codecov-io edited a comment on issue #8557: [WIP][dashboard scoped filter] part 1: scope selector modal
URL: https://github.com/apache/incubator-superset/pull/8557#issuecomment-553585972
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8557?src=pr&el=h1) Report
> Merging [#8557](https://codecov.io/gh/apache/incubator-superset/pull/8557?src=pr&el=desc) into [feature--dashboard-scoped-filter](https://codecov.io/gh/apache/incubator-superset/commit/90275fe991a97f328e1a24bd5aa7030326ccf85e?src=pr&el=desc) will **increase** coverage by `5.1%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8557?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature--dashboard-scoped-filter #8557 +/- ##
===================================================================
+ Coverage 66.8% 71.9% +5.1%
===================================================================
Files 450 118 -332
Lines 22733 12467 -10266
Branches 2366 0 -2366
===================================================================
- Hits 15187 8965 -6222
+ Misses 7408 3502 -3906
+ Partials 138 0 -138
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8557?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==) | | |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [...perset/assets/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRFbXB0eUxheW91dC5qcw==) | | |
| [...ts/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRDb21wb25lbnRXaWR0aEZyb21Ecm9wLmpz) | | |
| [...erset/assets/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9RdWVyeVNlYXJjaC5qc3g=) | | |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | | |
| [superset/assets/src/welcome/DashboardTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy93ZWxjb21lL0Rhc2hib2FyZFRhYmxlLmpzeA==) | | |
| [...erset/assets/src/dashboard/util/injectCustomCss.js](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9pbmplY3RDdXN0b21Dc3MuanM=) | | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQWRob2NNZXRyaWNFZGl0UG9wb3Zlci5qc3g=) | | |
| ... and [311 more](https://codecov.io/gh/apache/incubator-superset/pull/8557/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8557?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8557?src=pr&el=footer). Last update [90275fe...39182f9](https://codecov.io/gh/apache/incubator-superset/pull/8557?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org