[GitHub] [spark] srowen commented on a change in pull request #30470: [SPARK-33495][BUILD] Remove commons-logging.jar's dependency

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #30470:
URL: https://github.com/apache/spark/pull/30470#discussion_r531132041



##########
File path: pom.xml
##########
@@ -1091,6 +1109,12 @@
         <artifactId>hadoop-client-runtime</artifactId>
         <version>${hadoop.version}</version>
         <scope>${hadoop.deps.scope}</scope>
+        <exclusions>
+          <exclusion>
+            <groupId>commons-logging</groupId>
+            <artifactId>commons-logging</artifactId>
+          </exclusion>
+        </exclusions>

Review comment:
       I'm always worried at some point something adds the slf4j -> commons-logging binding and then we have something circular here :) this might be fine. Is it helpful, like does it help get more log messages to the same place?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org