[GitHub] [kafka] bdesert commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

[GitBox <gi...@apache.org>]

bdesert commented on a change in pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#discussion_r739570175



##########
File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java
##########
@@ -152,6 +152,44 @@ public void testConfigPropertyFiltering() {
             .anyMatch(x -> x.name().equals("min.insync.replicas")), "should not replicate excluded properties");
     }
 
+    @Test
+    public void testConfigPropertyFilteringExclude() {

Review comment:
       @mimaison, thanks for the comments. Makes perfect sense.
   I'm adding integration test to address your suggestion.
   Along with that, i'm still keeping the unitTest committed before, so it will test configuration filtering _logic_ without integration. The method I've added to unitTest follows the suit of the very previous test `testConfigPropertyFiltering`, which tests **default** exclude list this particular way.
   I understand your concern of using connector's configuration instead of topic configuration. But since in unitTest we don't really create cluster's to retrieve topic's configuration, I find this way legit to test `MirrorSourceConnector.targetConfig`. Open for suggestions, though.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org