You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/22 02:03:10 UTC
[GitHub] [maven-resources-plugin] olamy opened a new pull request, #40: remove specific IDE m2e files
olamy opened a new pull request, #40:
URL: https://github.com/apache/maven-resources-plugin/pull/40
those files are specific to m2e they shouldn;t be stored in the Apache Maven sources
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MRESOURCES) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MRESOURCES-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MRESOURCES-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resources-plugin] olamy commented on pull request #40: remove specific IDE m2e files
Posted by GitBox <gi...@apache.org>.
olamy commented on PR #40:
URL: https://github.com/apache/maven-resources-plugin/pull/40#issuecomment-1322915721
cc @HannesWell @kwin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resources-plugin] alexsuter commented on pull request #40: remove specific IDE m2e files
Posted by "alexsuter (via GitHub)" <gi...@apache.org>.
alexsuter commented on PR #40:
URL: https://github.com/apache/maven-resources-plugin/pull/40#issuecomment-1484718277
Seems that this change has broken our Eclipse IDE integration. Don't know why this is no longer working, yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resources-plugin] HannesWell commented on pull request #40: remove specific IDE m2e files
Posted by "HannesWell (via GitHub)" <gi...@apache.org>.
HannesWell commented on PR #40:
URL: https://github.com/apache/maven-resources-plugin/pull/40#issuecomment-1487313347
> Seems that this change has broken our Eclipse IDE integration. Don't know why this is no longer working, yet.
Please try out the latest version of the Eclipse Maven integration m2e at https://download.eclipse.org/technology/m2e/releases/latest/
and if it still does not work please create a bug report at https://github.com/eclipse-m2e/m2e-core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resources-plugin] cstamas merged pull request #40: remove specific IDE m2e files
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #40:
URL: https://github.com/apache/maven-resources-plugin/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resources-plugin] olamy commented on pull request #40: remove specific IDE m2e files
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #40:
URL: https://github.com/apache/maven-resources-plugin/pull/40#issuecomment-1486274964
@alexsuter sorry for that but according to this comment https://github.com/apache/maven-resources-plugin/pull/40#pullrequestreview-1189572912 it shouldn’t have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org