You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Peter Firmstone <ji...@zeus.net.au> on 2009/03/30 03:53:48 UTC

Re: [jira] Issue Comment Edited: (RIVER-272) ClassDep.java relies on Sun specific Internal JDK API

Jonathan Costers (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/RIVER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693546#action_12693546 ] 
>
> Jonathan Costers edited comment on RIVER-272 at 3/29/09 5:50 PM:
> -----------------------------------------------------------------
>
> Thanks for the code! I'm testing it right now.
> If all seems to work, I'll provide a patch for build.xml and integrationtest.xml.
>
> EDIT: 
> I have successfully built and run ClassDepend on a number of JAR targets in the QA suite build. It seems to calculate the same dependencies as ClassDep. 
> However, the command line options are not the same as for ClassDep, so integrating it into the build would require quite some work. Not impossible though.
>   
I was thinking of implementing a ProxyClassDep to convert the command 
line input from ClassDepLoader to ClassDepend or fallback to ClassDep 
(if its in the classpath) when ClassDepend doesn't implement the 
functionality.

> Also, how do we best handle the dependency on ASM? 
>   
Perhaps the library be located at trunk/lib/asm-2.2.3.jar and 
trunk/lib/asm-commons-2.2.3.jar  and be downloaded and updated via svn.
The build scripts need to change the namespace with jarjar to, for 
example, org.river.lib.asm.* to get it out of the way for client code. 
> Best
> Jonathan
>
>       was (Author: jcosters):
>     Thanks for the code! I'm testing it right now.
> If all seems to work, I'll provide a patch for build.xml and integrationtest.xml too.
>
> Best
> Jonathan
>   
>   
>> ClassDep.java relies on Sun specific Internal JDK API 
>> ------------------------------------------------------
>>
>>                 Key: RIVER-272
>>                 URL: https://issues.apache.org/jira/browse/RIVER-272
>>             Project: River
>>          Issue Type: Improvement
>>          Components: com_sun_jini_tool
>>    Affects Versions: jtsk_2.1
>>         Environment: Windows XP, JDK 1.4 - JDK 1.6, Eclipse 3.3 IDE
>>            Reporter: Hakan Kocakulak
>>         Attachments: classdepend.zip, classdepend_backport.tgz
>>
>>
>> ClassDep.java relies on Sun specific Internal JDK API 
>> import sun.tools.java.BinaryClass;
>>     
>>> import sun.tools.java.ClassDeclaration; import 
>>> sun.tools.java.ClassFile; import sun.tools.java.ClassNotFound; import 
>>> sun.tools.java.ClassPath; import sun.tools.java.Constants; import 
>>> sun.tools.java.Environment; import sun.tools.java.Identifier; import 
>>> sun.tools.java.MemberDefinition; import sun.tools.java.Package; import 
>>> sun.tools.java.Type;
>>>       
>> while building from eclipse IDE, IDE do not add these Classes to classpath and can not build project.
>>     
>
>   


Re: [jira] Issue Comment Edited: (RIVER-272) ClassDep.java relies on Sun specific Internal JDK API

Posted by Peter Firmstone <ji...@zeus.net.au>.
Tim Blackman wrote:
> On Mar 29, 2009, at 9:53 PM, Peter Firmstone wrote:
>
>>> Thanks for the code! I'm testing it right now.
>>> If all seems to work, I'll provide a patch for build.xml and 
>>> integrationtest.xml.
>>>
>>> EDIT: I have successfully built and run ClassDepend on a number of 
>>> JAR targets in the QA suite build. It seems to calculate the same 
>>> dependencies as ClassDep. However, the command line options are not 
>>> the same as for ClassDep, so integrating it into the build would 
>>> require quite some work. Not impossible though.
>>
>> I was thinking of implementing a ProxyClassDep to convert the command 
>> line input from ClassDepLoader to ClassDepend or fallback to ClassDep 
>> (if its in the classpath) when ClassDepend doesn't implement the 
>> functionality.
>
> What capabilities does ClassDep have that are not supported by 
> ClassDepend?
>
> - Tim
>
I haven't done the comparison to ClassDep yet, however I'm reading into 
your comment that ClassDepend does have full equivalent functionality 
and can probably do more as there are some class dependencies that 
ClassDep misses.  If this is the case it certainly makes the integration 
much easier.   If so, instead of setting up a proxy, I'll probably make 
ClassDep wrap ClassDepend, and reimplement its methods by forwarding 
requests onto ClassDepend.  Will look into it more on the weekend.

N.B. Thanks for the code, it was much better than I expected. I checked 
around on the net to get some background on whom I'm talking to on this 
list and must say I'm impressed.

Cheers,

Peter.

Re: [jira] Issue Comment Edited: (RIVER-272) ClassDep.java relies on Sun specific Internal JDK API

Posted by Tim Blackman <Ti...@sun.com>.
On Mar 29, 2009, at 9:53 PM, Peter Firmstone wrote:

>> Thanks for the code! I'm testing it right now.
>> If all seems to work, I'll provide a patch for build.xml and  
>> integrationtest.xml.
>>
>> EDIT: I have successfully built and run ClassDepend on a number of  
>> JAR targets in the QA suite build. It seems to calculate the same  
>> dependencies as ClassDep. However, the command line options are not  
>> the same as for ClassDep, so integrating it into the build would  
>> require quite some work. Not impossible though.
>
> I was thinking of implementing a ProxyClassDep to convert the  
> command line input from ClassDepLoader to ClassDepend or fallback to  
> ClassDep (if its in the classpath) when ClassDepend doesn't  
> implement the functionality.

What capabilities does ClassDep have that are not supported by  
ClassDepend?

- Tim