You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/03/11 00:52:23 UTC

[GitHub] [servicecomb-java-chassis] wujimin commented on issue #1116: What about to support zipkin tracing in spring-cloud-gateway in java-chassis?

wujimin commented on issue #1116: What about to support zipkin tracing in spring-cloud-gateway in java-chassis?
URL: https://github.com/apache/servicecomb-java-chassis/issues/1116#issuecomment-471372108
 
 
   because forward logic of zuul or spring cloud gateway is not controlled by ServiceComb
   so i think we no need to do anything for these cases
   just use spring modules directly 
   and enhance handlers/handler-tracing-zipkin to inherit spans from http header like inherit traceId in org.apache.servicecomb.core.Invocation#initTraceId(org.apache.servicecomb.core.tracing.TraceIdGenerator)
   
   if this enhance can resolve the problem, then we can delete following module:
   java-chassis-spring-boot/spring-boot-starter/spring-cloud-zuul-zipkin

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services