You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/03/10 00:57:31 UTC

Review Request 44601: revoke the unnecessary code change in DistributedTestCase which caused side-effect

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44601/
-----------------------------------------------------------

Review request for geode and Dan Smith.


Bugs: GEODE-589
    https://issues.apache.org/jira/browse/GEODE-589


Repository: geode


Description
-------

The fix for GEODE-1052 on DistributedTestCase.java is unnecessary and it caused other tests fail.

Revoke this part.


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java 1203570 

Diff: https://reviews.apache.org/r/44601/diff/


Testing
-------


Thanks,

xiaojian zhou


Re: Review Request 44601: revoke the unnecessary code change in DistributedTestCase which caused side-effect

Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44601/#review122834
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Smith


On March 9, 2016, 11:57 p.m., xiaojian zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44601/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 11:57 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-589
>     https://issues.apache.org/jira/browse/GEODE-589
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The fix for GEODE-1052 on DistributedTestCase.java is unnecessary and it caused other tests fail.
> 
> Revoke this part.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java 1203570 
> 
> Diff: https://reviews.apache.org/r/44601/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>