You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "gortiz (via GitHub)" <gi...@apache.org> on 2023/08/31 06:30:20 UTC
[GitHub] [pinot] gortiz commented on a diff in pull request #11467: sql between function should be inclusive
gortiz commented on code in PR #11467:
URL: https://github.com/apache/pinot/pull/11467#discussion_r1311152875
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ComparisonFunctions.java:
##########
@@ -61,6 +61,6 @@ public static boolean equals(double a, double b) {
@ScalarFunction
public static boolean between(double val, double a, double b) {
- return val > a && val < b;
+ return val >= a && val <= b;
Review Comment:
Strange that we didn't have a test before. Could you add one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org