[GitHub] cgivre commented on a change in pull request #6610: Add support to Apache Drill

[GitBox <gi...@apache.org>]

cgivre commented on a change in pull request #6610: Add support to Apache Drill
URL: https://github.com/apache/incubator-superset/pull/6610#discussion_r246178369
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1560,8 +1560,16 @@ def tables(self, db_id, schema, substr, force_refresh='false'):
             max_tables = max_items * len(table_names) // total_items
             max_views = max_items * len(view_names) // total_items
 
-        table_options = [{'value': tn, 'label': tn}
-                         for tn in table_names[:max_tables]]
+        # Make modifications for Drill
+        # This hack (and it's a total hack) replaces the dot from the file extension
+        # with '@@@' to prevent Superset from misinterpreting the schema
+        if "drill+sadrill" in database.sqlalchemy_uri_decrypted:
 
 Review comment:
   @mistercrunch 
   Perhaps hack was too strong a word, but I couldn't find an appropriate hook. 
   The drop down is now populated as follows:
   <option value="filename@@@csv">filename.csv</option>
   
   Do you have any suggestions as to either how to write a hook to properly encode/decode the URL or otherwise get the arguments passed correctly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org