You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by "GYXkeep (via GitHub)" <gi...@apache.org> on 2023/05/16 04:56:54 UTC
[GitHub] [incubator-hugegraph] GYXkeep opened a new pull request, #2211: break out of unnecessary loops
GYXkeep opened a new pull request, #2211:
URL: https://github.com/apache/incubator-hugegraph/pull/2211
The loop in this method can jump out directly when the condition is met, avoiding useless loops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on pull request #2211: refact(core): early stop unnecessary loops in edge cache
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #2211:
URL: https://github.com/apache/incubator-hugegraph/pull/2211#issuecomment-1549998552
TODO: Also another CI problem need to fix, [refer link](https://github.com/apache/incubator-hugegraph/actions/runs/4994363768)
<img width="1431" alt="image" src="https://github.com/apache/incubator-hugegraph/assets/17706099/846c2e04-a139-4ebf-8259-643e406ad43e">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin merged pull request #2211: refact(core): early stop unnecessary loops in edge cache
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #2211:
URL: https://github.com/apache/incubator-hugegraph/pull/2211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on pull request #2211: refact(core): early stop unnecessary loops in edge cache
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #2211:
URL: https://github.com/apache/incubator-hugegraph/pull/2211#issuecomment-1549987690
Also mark the rocksdb raft test as a TODO problem, add it to the "help wanted tasks"
<img width="872" alt="image" src="https://github.com/apache/incubator-hugegraph/assets/17706099/c9626b95-d238-4004-9395-f71fda10fcf8">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #2211: break out of unnecessary loops
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2211:
URL: https://github.com/apache/incubator-hugegraph/pull/2211#issuecomment-1549044603
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2211?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2211](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2211?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cbb7dd2) into [master](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/267ff6d3a8d5791d9481643697c757bc0cc6cf8f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (267ff6d) will **decrease** coverage by `12.86%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #2211 +/- ##
=============================================
- Coverage 61.53% 48.67% -12.86%
- Complexity 484 652 +168
=============================================
Files 497 497
Lines 40572 40573 +1
Branches 5663 5663
=============================================
- Hits 24965 19748 -5217
- Misses 13061 18699 +5638
+ Partials 2546 2126 -420
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ugegraph/backend/cache/CachedGraphTransaction.java](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1Z2VncmFwaC9iYWNrZW5kL2NhY2hlL0NhY2hlZEdyYXBoVHJhbnNhY3Rpb24uamF2YQ==) | `75.78% <100.00%> (-4.64%)` | :arrow_down: |
... and [173 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2211/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org