You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/01/30 13:24:54 UTC
Review Request 56077: Update slider tarball before uploading to DFS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-19776
https://issues.apache.org/jira/browse/AMBARI-19776
Repository: ambari
Description
-------
Diffs
-----
ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a
Diff: https://reviews.apache.org/r/56077/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 56077: Update slider tarball before uploading to
DFS
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Jan. 30, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/scripts/Ambaripreupload.py, line 141
> > <https://reviews.apache.org/r/56077/diff/1/?file=1618965#file1618965line141>
> >
> > Remove the hardcoding of "/usr/hdp".
> > Use stack_root instead.
stack_root is get from /configurations/cluster-env/stack_root or script.py.
Neither Ambaripreupload.py uses script.py nor any configuration. This is a simple script for for pre-creation which has all the configs hardcoded in it.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/#review163538
-----------------------------------------------------------
On Jan. 30, 2017, 1:24 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56077/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 1:24 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-19776
> https://issues.apache.org/jira/browse/AMBARI-19776
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a
>
> Diff: https://reviews.apache.org/r/56077/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 56077: Update slider tarball before uploading to
DFS
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/#review163538
-----------------------------------------------------------
ambari-server/src/main/resources/scripts/Ambaripreupload.py (line 141)
<https://reviews.apache.org/r/56077/#comment234988>
Remove the hardcoding of "/usr/hdp".
Use stack_root instead.
- Alejandro Fernandez
On Jan. 30, 2017, 1:24 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56077/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 1:24 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-19776
> https://issues.apache.org/jira/browse/AMBARI-19776
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a
>
> Diff: https://reviews.apache.org/r/56077/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 56077: Update slider tarball before uploading to
DFS
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/#review163526
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 30, 2017, 1:24 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56077/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 1:24 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-19776
> https://issues.apache.org/jira/browse/AMBARI-19776
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a
>
> Diff: https://reviews.apache.org/r/56077/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 56077: Update slider tarball before uploading to
DFS
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/#review163513
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 30, 2017, 3:24 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56077/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 3:24 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-19776
> https://issues.apache.org/jira/browse/AMBARI-19776
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a
>
> Diff: https://reviews.apache.org/r/56077/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>