[GitHub] [superset] villebro commented on a change in pull request #18658: fix: dataset modal doesn't work in dev mode

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #18658:
URL: https://github.com/apache/superset/pull/18658#discussion_r803478631



##########
File path: superset-frontend/webpack.config.js
##########
@@ -344,6 +344,11 @@ const config = {
         ],
         use: [babelLoader],
       },
+      {
+        test: /\.js$/,
+        include: /node_modules\/react-dom/,
+        use: ['react-hot-loader/webpack'],
+      },

Review comment:
       I wonder if we should consider using `@hot-loader/react-dom`, as maybe there are other patches there, too, that we're just unaware of right now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org