You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2018/02/13 04:57:31 UTC
spark git commit: [SPARK-23379][SQL] skip when setting the same
current database in HiveClientImpl
Repository: spark
Updated Branches:
refs/heads/master c1bcef876 -> ed4e78bd6
[SPARK-23379][SQL] skip when setting the same current database in HiveClientImpl
## What changes were proposed in this pull request?
If the target database name is as same as the current database, we should be able to skip one metastore access.
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: Feng Liu <fe...@databricks.com>
Closes #20565 from liufengdb/remove-redundant.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ed4e78bd
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ed4e78bd
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ed4e78bd
Branch: refs/heads/master
Commit: ed4e78bd606e7defc2cd01a5c2e9b47954baa424
Parents: c1bcef8
Author: Feng Liu <fe...@databricks.com>
Authored: Mon Feb 12 20:57:26 2018 -0800
Committer: gatorsmile <ga...@gmail.com>
Committed: Mon Feb 12 20:57:26 2018 -0800
----------------------------------------------------------------------
.../org/apache/spark/sql/hive/client/HiveClientImpl.scala | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/ed4e78bd/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
index c223f51..146fa54 100644
--- a/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
+++ b/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
@@ -292,10 +292,12 @@ private[hive] class HiveClientImpl(
}
private def setCurrentDatabaseRaw(db: String): Unit = {
- if (databaseExists(db)) {
- state.setCurrentDatabase(db)
- } else {
- throw new NoSuchDatabaseException(db)
+ if (state.getCurrentDatabase != db) {
+ if (databaseExists(db)) {
+ state.setCurrentDatabase(db)
+ } else {
+ throw new NoSuchDatabaseException(db)
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org