You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/06/03 14:43:21 UTC

[GitHub] [trafficcontrol] dangogh opened a new pull request #3656: fix seeds.sql

dangogh opened a new pull request #3656: fix seeds.sql
URL: https://github.com/apache/trafficcontrol/pull/3656
 
 
   
   ## What does this PR (Pull Request) do?
   - [x] This PR fixes a bug introduced in  PR #3524.
   
   It fixes one issue introduced when the `go` migration was removed.   Several `insert` sql commands did not protect against the same row already existing in the db.  This fixes that issue.
   
   No tests or documentation or CHANGELOG changes needed.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   `db/admin -env <test> seed` where `<test>` is the name of an environment with a previously populated database.   No error should be produced.
   
   ## If this is a bug fix, what versions of Traffic Ops are affected?
   master (41cc65a8621094fd7403574e0dd6f9c36b49ea87)
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services