You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/03/26 21:50:23 UTC
[kudu-CR] dist-test: improve error message when no tests run
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12865
Change subject: dist-test: improve error message when no tests run
......................................................................
dist-test: improve error message when no tests run
This patch improves the error message displayed when no matching tests
are found to run.
Previous error message for the "loop" action:
../build-support/dist_test.py loop --num-instances 1024 -- bin/remote_ksck-test --gtest_filter=RemoteKsckTest.TestChecksumSnapshotLastingLongerThanAHM --stress-cpu-threads=16
isolate: at least one isolate file required
2019-03-26 13:24:19,260 ERROR: Failed to run isolate
Traceback (most recent call last):
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 606, in <module>
main(sys.argv[1:])
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 601, in main
args.func(p, args)
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 513, in loop_test
run_isolate(staging)
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 396, in run_isolate
'--'] + staging.gen_json_paths())
File "/usr/local/lib/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['isolate', 'batcharchive', '-isolate-server=http://isolate.cloudera.org:4242/', '-dump-json=/home/mpercy/src/kudu/build/isolate/dump.json', '--']' returned non-zero exit status 1
New error message:
../build-support/dist_test.py loop --num-instances 1024 -- bin/remote_ksck-test --gtest_filter=RemoteKsckTest.TestChecksumSnapshotLastingLongerThanAHM --stress-cpu-threads=16
Traceback (most recent call last):
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 608, in <module>
main(sys.argv[1:])
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 603, in main
args.func(p, args)
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 494, in loop_test
raise Exception("No matching tests found for pattern %s" % tests_regex)
Exception: No matching tests found for pattern ^remote_ksck-test(\.[0-9]+)?$
Change-Id: If26dad45a8c75f773b36a1255b53b5dac006edf3
---
M build-support/dist_test.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/12865/1
--
To view, visit http://gerrit.cloudera.org:8080/12865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If26dad45a8c75f773b36a1255b53b5dac006edf3
Gerrit-Change-Number: 12865
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] dist-test: improve error message when no tests run
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12865 )
Change subject: dist-test: improve error message when no tests run
......................................................................
Patch Set 1:
> Could also move the check and exception into get_tests_execution. Doesn't matter either way though.
I thought about doing that, and it would save a little bit of duplication, but returning an empty list when nothing is found is a reasonable API as well. It seems like a better separation of responsibilities to throw one level above that.
--
To view, visit http://gerrit.cloudera.org:8080/12865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26dad45a8c75f773b36a1255b53b5dac006edf3
Gerrit-Change-Number: 12865
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 26 Mar 2019 22:58:05 +0000
Gerrit-HasComments: No
[kudu-CR] dist-test: improve error message when no tests run
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12865 )
Change subject: dist-test: improve error message when no tests run
......................................................................
dist-test: improve error message when no tests run
This patch improves the error message displayed when no matching tests
are found to run.
Previous error message for the "loop" action:
../build-support/dist_test.py loop --num-instances 1024 -- bin/remote_ksck-test --gtest_filter=RemoteKsckTest.TestChecksumSnapshotLastingLongerThanAHM --stress-cpu-threads=16
isolate: at least one isolate file required
2019-03-26 13:24:19,260 ERROR: Failed to run isolate
Traceback (most recent call last):
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 606, in <module>
main(sys.argv[1:])
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 601, in main
args.func(p, args)
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 513, in loop_test
run_isolate(staging)
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 396, in run_isolate
'--'] + staging.gen_json_paths())
File "/usr/local/lib/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['isolate', 'batcharchive', '-isolate-server=http://isolate.cloudera.org:4242/', '-dump-json=/home/mpercy/src/kudu/build/isolate/dump.json', '--']' returned non-zero exit status 1
New error message:
../build-support/dist_test.py loop --num-instances 1024 -- bin/remote_ksck-test --gtest_filter=RemoteKsckTest.TestChecksumSnapshotLastingLongerThanAHM --stress-cpu-threads=16
Traceback (most recent call last):
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 608, in <module>
main(sys.argv[1:])
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 603, in main
args.func(p, args)
File "/home/mpercy/src/kudu/build-support/dist_test.py", line 494, in loop_test
raise Exception("No matching tests found for pattern %s" % tests_regex)
Exception: No matching tests found for pattern ^remote_ksck-test(\.[0-9]+)?$
Change-Id: If26dad45a8c75f773b36a1255b53b5dac006edf3
Reviewed-on: http://gerrit.cloudera.org:8080/12865
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/dist_test.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If26dad45a8c75f773b36a1255b53b5dac006edf3
Gerrit-Change-Number: 12865
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] dist-test: improve error message when no tests run
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12865 )
Change subject: dist-test: improve error message when no tests run
......................................................................
Patch Set 1: Code-Review+2
Could also move the check and exception into get_tests_execution. Doesn't matter either way though.
--
To view, visit http://gerrit.cloudera.org:8080/12865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26dad45a8c75f773b36a1255b53b5dac006edf3
Gerrit-Change-Number: 12865
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 26 Mar 2019 22:22:51 +0000
Gerrit-HasComments: No