You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "aldettinger (via GitHub)" <gi...@apache.org> on 2024/07/23 14:12:48 UTC
[PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
aldettinger opened a new pull request, #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289#discussion_r1689421120
##########
poms/bom/src/main/generated/flattened-reduced-pom.xml:
##########
@@ -8428,6 +8412,78 @@
<artifactId>quarkus-hazelcast-client-deployment</artifactId>
<version>4.0.0</version>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-runtime-spi</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-deployment</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j</artifactId>
+ <version>0.32.0</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ <version>0.32.0</version>
+ <type>test-jar</type>
+ <classifier>tests</classifier>
+ </dependency>
+ <dependency>
Review Comment:
That looks like an interesting idea. Let investigate to update this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289#discussion_r1688678637
##########
poms/bom/src/main/generated/flattened-reduced-pom.xml:
##########
@@ -8428,6 +8412,78 @@
<artifactId>quarkus-hazelcast-client-deployment</artifactId>
<version>4.0.0</version>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-runtime-spi</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-deployment</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j</artifactId>
+ <version>0.32.0</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ <version>0.32.0</version>
+ <type>test-jar</type>
+ <classifier>tests</classifier>
+ </dependency>
+ <dependency>
Review Comment:
> Would the dependency management include the `quarkus-langchain4j-bom`
Everything in `camel-quarkus-bom` should in theory make its way into the platform generated `quarkus-camel-bom`. So the langchain4j bits should get propagated.
You can verify it locally by building the platform with the CQ SNAPSHOT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289#discussion_r1688306891
##########
poms/bom/src/main/generated/flattened-reduced-pom.xml:
##########
@@ -8428,6 +8412,78 @@
<artifactId>quarkus-hazelcast-client-deployment</artifactId>
<version>4.0.0</version>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-runtime-spi</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-deployment</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j</artifactId>
+ <version>0.32.0</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ <version>0.32.0</version>
+ <type>test-jar</type>
+ <classifier>tests</classifier>
+ </dependency>
+ <dependency>
Review Comment:
Need more thinking indeed, jsoup & lombok would be too high a price.
Actually, I'm not even sure it would have the desired effect.
Like, let's say this pr is integrated and a next quarkus-platform release embed it.
Would the dependency management include the `quarkus-langchain4j-bom` ? Like an application depending on quarkus-langchain4j-ollama would have the right version pulled from dependency management ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289#discussion_r1689414290
##########
poms/bom/src/main/generated/flattened-reduced-pom.xml:
##########
@@ -8428,6 +8412,78 @@
<artifactId>quarkus-hazelcast-client-deployment</artifactId>
<version>4.0.0</version>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-runtime-spi</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-deployment</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j</artifactId>
+ <version>0.32.0</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ <version>0.32.0</version>
+ <type>test-jar</type>
+ <classifier>tests</classifier>
+ </dependency>
+ <dependency>
Review Comment:
We could maybe add a section to the docs about importing the BOM in user apps. You could add an asciidoc attribute to `antora.yml` for the langchain4j version so that it could be used in a code snippet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289#issuecomment-2248036285
Just a small fix coming and it should be ready to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289#discussion_r1688170532
##########
poms/bom/src/main/generated/flattened-reduced-pom.xml:
##########
@@ -8428,6 +8412,78 @@
<artifactId>quarkus-hazelcast-client-deployment</artifactId>
<version>4.0.0</version>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-runtime-spi</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-deployment</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j</artifactId>
+ <version>0.32.0</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ <version>0.32.0</version>
+ <type>test-jar</type>
+ <classifier>tests</classifier>
+ </dependency>
+ <dependency>
Review Comment:
I think the platform generator plugin would force versions that are 'owned' by their respective platform members. E.g Infinispan versions would come from `quarkus-core` & AWS versions from`quarkus-amazon-services`.
Importing `langchain4j-bom` in its entirety is perhaps a bit heavyweight. It's adding some stuff that I'd prefer to not have in the BOM, like lombok, jsoup and a test-jar. Maybe we can tweak the `cq-maven-plugin` config to restrict what's included to `dev.langchain4j:*` (maybe even `*` is too much).
Or, if there's just a known set of dependencies that we think are used commonly, maybe we just add those individually to the BOM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289#discussion_r1689400215
##########
poms/bom/src/main/generated/flattened-reduced-pom.xml:
##########
@@ -8428,6 +8412,78 @@
<artifactId>quarkus-hazelcast-client-deployment</artifactId>
<version>4.0.0</version>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-runtime-spi</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-deployment</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j</artifactId>
+ <version>0.32.0</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ <version>0.32.0</version>
+ <type>test-jar</type>
+ <classifier>tests</classifier>
+ </dependency>
+ <dependency>
Review Comment:
After investigations, `jsoup` and `lombok` are used at deep langchain4j level. Managing them seems unmaintanable. Unless there are other ideas, the best way would be too let users force the versions by importing the `quarkus-langchain4j-bom`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger merged PR #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Quarkus LangChain4j version alignment #6288 [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #6289:
URL: https://github.com/apache/camel-quarkus/pull/6289#discussion_r1688146815
##########
poms/bom/src/main/generated/flattened-reduced-pom.xml:
##########
@@ -8428,6 +8412,78 @@
<artifactId>quarkus-hazelcast-client-deployment</artifactId>
<version>4.0.0</version>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-runtime-spi</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkiverse.langchain4j</groupId>
+ <artifactId>quarkus-langchain4j-core-deployment</artifactId>
+ <version>0.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j</artifactId>
+ <version>0.32.0</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ <version>0.32.0</version>
+ <type>test-jar</type>
+ <classifier>tests</classifier>
+ </dependency>
+ <dependency>
Review Comment:
@jamesnetherton On the top of your mind, would any of the following dependencies below generate issues on the platform ? Like aws ? infinispan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org