[GitHub] [incubator-devlake] klesh commented on a diff in pull request #5977: feat: allow users to configure the sync modes for plugins that suppor…

["klesh (via GitHub)" <gi...@apache.org>]

klesh commented on code in PR #5977:
URL: https://github.com/apache/incubator-devlake/pull/5977#discussion_r1314474917


##########
backend/helpers/pluginhelper/api/api_collector_with_state.go:
##########
@@ -153,10 +156,12 @@ func NewStatefulApiCollectorForFinalizableEntity(args FinalizableApiCollectorArg
 	if err != nil {
 		return nil, err
 	}
-
 	// // prepare the basic variables
-	var isIncremental = manager.IsIncremental()
 	var createdAfter *time.Time
+	var isIncremental = manager.IsIncremental()
+	if manager.Ctx.TaskContext().FullSync() {
+		isIncremental = false
+	}

Review Comment:
   I think it is better to put it into `manager.IsIncremental` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org