You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/25 07:33:29 UTC
[GitHub] [incubator-kvrocks] caipengbo opened a new pull request, #668: Fix get rocksdb ops tcl test case
caipengbo opened a new pull request, #668:
URL: https://github.com/apache/incubator-kvrocks/pull/668
fix #658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] caipengbo commented on pull request #668: Fix get rocksdb ops tcl test case
Posted by GitBox <gi...@apache.org>.
caipengbo commented on PR #668:
URL: https://github.com/apache/incubator-kvrocks/pull/668#issuecomment-1166389190
> I think we can change the assert condition to guarantee those ops metrics can't be zero.
Yes, this operation is the metric from rocksdb, which should return as correct as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #668: Fix get rocksdb ops tcl test case
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #668:
URL: https://github.com/apache/incubator-kvrocks/pull/668#issuecomment-1166223237
As commented in https://github.com/apache/incubator-kvrocks/issues/658#issuecomment-1166219636, seems our current ops comparison is not so determined since it depends on the server cron to record metrics, also ops will be changed by the time slot. I think we can change the assert condition to guarantee those ops metrics can't be zero. How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #668: Fix get rocksdb ops tcl test case
Posted by GitBox <gi...@apache.org>.
git-hulk merged PR #668:
URL: https://github.com/apache/incubator-kvrocks/pull/668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #668: Fix get rocksdb ops tcl test case
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #668:
URL: https://github.com/apache/incubator-kvrocks/pull/668#issuecomment-1166412124
> > I think we can change the assert condition to guarantee those ops metrics can't be zero.
>
> Yes, this operation is the metric from rocksdb, which should return as correct as possible.
>
> And how about using put ops compare to other ops?
For those ops metrics would be affected by other test cases if they have many get/put/seek operations, coz our metrics calculate range is 16s. Can see: https://github.com/apache/incubator-kvrocks/blob/0b2de8ab6f661d90a279a0c11096755d7733b11c/src/stats.cc#L108
I think it's ok to check ops > 0 only for current implementation, we should export those metrics counter if want to check them more precisely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org