You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "patsonluk (via GitHub)" <gi...@apache.org> on 2023/03/15 03:13:43 UTC
[GitHub] [solr] patsonluk opened a new pull request, #1461: SAI-4401: Experimental DocCollection Refactoring
patsonluk opened a new pull request, #1461:
URL: https://github.com/apache/solr/pull/1461
Experimental changes to see efforts involved to extract the PRS supplier out from `DocCollection` to keep `DocCollection` immutable. Some background in https://fullstory.atlassian.net/browse/SAI-4401
Pros:
1. When `DocCollection` is fully immutable, the existing Solr logic calling it (and making such assumption) could have easier handling (less concern with state changes that induces race conditions etc)
2. Keep `DocCollection` logic simple as a pure container that simply assign the provided values into itself, this avoid unexpected ZK operations/fetches that trigger unexpected exceptions for caller
3. No longer need to worry about copy operations (such as `DocCollection.copyWithSlices`) would re-fetch PRS entries (since DocCollection no longer fetches anything). We might not need to add extra lazy loading to PRS as re-fetch might not be a concern anymore
This is fully just quick exploratory work to see if a modified flow would still work. I have not really done any testings yet. Really simple ZkStateWriter and ZkStateReader tests did pass.
Will run ./gradlew check and i do expect seeing some failures 😓
Be nice to get some thoughts from everyone though, especially @chatman and @noblepaul . Many thanks!! 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] patsonluk closed pull request #1461: SAI-4401: Experimental DocCollection Refactoring
Posted by "patsonluk (via GitHub)" <gi...@apache.org>.
patsonluk closed pull request #1461: SAI-4401: Experimental DocCollection Refactoring
URL: https://github.com/apache/solr/pull/1461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org