You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "srielau (via GitHub)" <gi...@apache.org> on 2023/01/23 14:46:09 UTC

[GitHub] [spark] srielau commented on a diff in pull request #39701: [SPARK-41489][SQL] Assign name to _LEGACY_ERROR_TEMP_2415

srielau commented on code in PR #39701:
URL: https://github.com/apache/spark/pull/39701#discussion_r1084146025


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -933,6 +933,12 @@
     ],
     "sqlState" : "42604"
   },
+  "INVALID_TYPE_FOR_FILTER_EXPR" : {

Review Comment:
   It isn't really a parameter. It's debatable whether it should be a subclass. But DATATYPE_MISMATCH is really turning into a catchall. I would either leave it as is, or make it:
   DATATYPE_MISMATCH.FILTER_NOT_BOOLEAN or so..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org