You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/05/31 10:47:29 UTC
[GitHub] incubator-zeppelin pull request: fix width and not close li tag in...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/938
fix width and not close li tag in searchbar
### What is this PR for?
closed li tag.
and Add a tooltip, and reduced the size of the horizontal search bar.
### What type of PR is it?
Bug Fix and Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-930
### How should this be tested?
It changes the browser horizontal size.
Use the search feature.
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin fix/ZEPPELIN-930
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/938.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #938
----
commit 0bd17856e587f00dc265f66021057aa8b8c8ef78
Author: CloverHearts <cl...@gmail.com>
Date: 2016-05-31T10:40:48Z
fix width and not close li tag in searchbar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #938: ZEPPELIN-930 ] fix width and not close...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/938
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #938: ZEPPELIN-930 ] fix width and not close li tag...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/938
@cloverhearts Thanks for addressing that! LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-930 ] fix width and not close li t...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/938
@bzz Thank you for you're review.
i will reverting placeholder text.
@minahlee @AhyoungRyu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-930 ] fix width and not close li t...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/938
@cloverhearts Good catch to close `<li>` tag \U0001f44d Is there any particular reason that you changed `placeholder` to `tooltip` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-930 ] fix width and not close li t...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/938
Looks great to me.
Let's merge after reverting placeholder text back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-930 ] fix width and not close li t...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/938
<img width="528" alt="02" src="https://cloud.githubusercontent.com/assets/10525473/15712410/360feac2-284d-11e6-986c-3ba99e91ec5e.png">
<img width="1280" alt="01" src="https://cloud.githubusercontent.com/assets/10525473/15712409/360dbf22-284d-11e6-9062-6937287e77de.png">
Modification was completed.
Please review for this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #938: ZEPPELIN-930 ] fix width and not close li tag...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/938
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #938: ZEPPELIN-930 ] fix width and not close li tag...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/938
Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---