You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by "abdullahselek (via GitHub)" <gi...@apache.org> on 2023/08/21 15:24:52 UTC

[GitHub] [mxnet] abdullahselek opened a new pull request, #21213: BUGFIX: Remove type `onp.bool`.

abdullahselek opened a new pull request, #21213:
URL: https://github.com/apache/mxnet/pull/21213

   I have to built mxnet locally on my M1 machine and then installed. But when I import the lib it threw `AttributeError` error with message `module 'numpy' has no attribute 'bool'`. This PR is a fix for the deprecation issue.
   
   ## Description ##
   
   Remove type `onp.bool` as `np.bool` was a deprecated alias for the builtin `bool` with numpy version 1.20.
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mxnet] mxnet-bot commented on pull request #21213: BUGFIX: Remove type `onp.bool`.

Posted by "mxnet-bot (via GitHub)" <gi...@apache.org>.
mxnet-bot commented on PR #21213:
URL: https://github.com/apache/mxnet/pull/21213#issuecomment-1717123843

   Undefined action detected. 
   Permissible actions are : run ci [all], run ci [job1, job2] 
   Example : @mxnet-bot run ci [all] 
   Example : @mxnet-bot run ci [centos-cpu, clang]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mxnet] mxnet-bot commented on pull request #21213: BUGFIX: Remove type `onp.bool`.

Posted by "mxnet-bot (via GitHub)" <gi...@apache.org>.
mxnet-bot commented on PR #21213:
URL: https://github.com/apache/mxnet/pull/21213#issuecomment-1686543283

   Hey @abdullahselek , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [clang, centos-cpu, windows-gpu, website, windows-cpu, unix-cpu, unix-gpu, sanity, miscellaneous, edge, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mxnet] abdullahselek commented on pull request #21213: BUGFIX: Remove type `onp.bool`.

Posted by "abdullahselek (via GitHub)" <gi...@apache.org>.
abdullahselek commented on PR #21213:
URL: https://github.com/apache/mxnet/pull/21213#issuecomment-1717123245

   @mxnet-bot run ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mxnet] mxnet-bot commented on pull request #21213: BUGFIX: Remove type `onp.bool`.

Posted by "mxnet-bot (via GitHub)" <gi...@apache.org>.
mxnet-bot commented on PR #21213:
URL: https://github.com/apache/mxnet/pull/21213#issuecomment-1717123340

   Undefined action detected. 
   Permissible actions are : run ci [all], run ci [job1, job2] 
   Example : @mxnet-bot run ci [all] 
   Example : @mxnet-bot run ci [centos-cpu, clang]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mxnet] mxnet-bot commented on pull request #21213: BUGFIX: Remove type `onp.bool`.

Posted by "mxnet-bot (via GitHub)" <gi...@apache.org>.
mxnet-bot commented on PR #21213:
URL: https://github.com/apache/mxnet/pull/21213#issuecomment-1717124963

   Jenkins CI successfully triggered : [website, windows-gpu, centos-gpu, sanity, windows-cpu, miscellaneous, clang, unix-gpu, unix-cpu, centos-cpu, edge]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org