[GitHub] [superset] rusackas commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r829407858



##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
 
 // when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
 export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;

Review comment:
       THANK YOU. I spent a few minutes trying to find an example of the [AntD-native approach](https://stackoverflow.com/questions/61124992/is-it-possible-to-show-an-ant-design-tooltip-conditionally-only-when-the-content). I swear I had a CodePen example of this that I once wrote up, but I seem to have left it in my other coat. 
   
   The 200px is indeed arbitrary. It also doesn't seem to _matter_, thus my comment/screenshot above.
   
   I'm OK with setting a reasonable maximum column width. Exactly _how_ wide is up for grabs. Maybe @kasiazjc has opinions on the matter. We should also test/consider how the _contents_ of the cell are wrapped/truncated when hitting this maximum width.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org