You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wayang.apache.org by GitBox <gi...@apache.org> on 2022/01/15 10:27:59 UTC
[GitHub] [incubator-wayang] CalvinKirs opened a new pull request #54: [CI]Add UT check and delete RAT
CalvinKirs opened a new pull request #54:
URL: https://github.com/apache/incubator-wayang/pull/54
We have used the skywalking-eyes check license head, so we can remove RAT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] ro-pardo commented on pull request #54: [CI]Add UT check and delete RAT
Posted by GitBox <gi...@apache.org>.
ro-pardo commented on pull request #54:
URL: https://github.com/apache/incubator-wayang/pull/54#issuecomment-1013922168
@berttty That is exactly my point. Could it be inconvenient to only check the licenses after the push. Of course is great to add this new function, for sure has many other uses; but i think there is no reason to remove RAT by now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] ro-pardo merged pull request #54: [CI]Add UT check
Posted by GitBox <gi...@apache.org>.
ro-pardo merged pull request #54:
URL: https://github.com/apache/incubator-wayang/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] CalvinKirs commented on pull request #54: [CI]Add UT check and delete RAT
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #54:
URL: https://github.com/apache/incubator-wayang/pull/54#issuecomment-1014141846
> @berttty That is exactly my point. Could it be inconvenient to only check the licenses after the push. Of course is great to add this new function, for sure has many other uses; but i think there is no reason to remove RAT by now.
OK, I've restored the RAT, thanks for the reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] ro-pardo commented on pull request #54: [CI]Add UT check and delete RAT
Posted by GitBox <gi...@apache.org>.
ro-pardo commented on pull request #54:
URL: https://github.com/apache/incubator-wayang/pull/54#issuecomment-1013764785
@CalvinKirs Hi, seems very well. But it is nice to have the RAT for an early checking of the licenses while developing.
Could you preserve it in addition to your work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] berttty commented on pull request #54: [CI]Add UT check and delete RAT
Posted by GitBox <gi...@apache.org>.
berttty commented on pull request #54:
URL: https://github.com/apache/incubator-wayang/pull/54#issuecomment-1013920894
I guess what @ro-pardo is point out, it is when you are working in your local machine, because the `SkyWalking-Eyes` is focusing after you did the push, and the `RAT` it will analyze when your are working in your local machine.
Do am I wrong @ro-pardo ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] CalvinKirs commented on pull request #54: [CI]Add UT check and delete RAT
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #54:
URL: https://github.com/apache/incubator-wayang/pull/54#issuecomment-1013658912
I noticed that we have some check tools that still use the `RAT`, but are not affected by this PR change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] CalvinKirs commented on pull request #54: [CI]Add UT check and delete RAT
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #54:
URL: https://github.com/apache/incubator-wayang/pull/54#issuecomment-1013814415
>
hi, currently we only use it to detect license headers in our Travis CI, but we have used `SkyWalking-Eyes` for detection (I will add check license dep later), its function is more powerful, and the community is very active. So I think we can remove the `RAT`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org