You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/20 18:00:41 UTC
[GitHub] [rocketmq] imaffe opened a new pull request #2018: [ISSUE #1807] only increase hashSlotCount when using slot for the first time
imaffe opened a new pull request #2018:
URL: https://github.com/apache/rocketmq/pull/2018
## What is the purpose of the change
#1807
1. check before update `hashSlotCount`
## Brief changelog
The build process failed, but failed at a place not related to this change. Need to further look into it
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #2018: [ISSUE #1807] only increase hashSlotCount when using slot for the first time
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #2018:
URL: https://github.com/apache/rocketmq/pull/2018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #2018: [ISSUE #1807] only increase hashSlotCount when using slot for the first time
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2018:
URL: https://github.com/apache/rocketmq/pull/2018#issuecomment-632595815
The code is ok. Plz change the target branch to develop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin removed a comment on pull request #2018: [ISSUE #1807] only increase hashSlotCount when using slot for the first time
Posted by GitBox <gi...@apache.org>.
RongtongJin removed a comment on pull request #2018:
URL: https://github.com/apache/rocketmq/pull/2018#issuecomment-632595815
The code is ok. Plz change the target branch to develop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2018: [ISSUE #1807] only increase hashSlotCount when using slot for the first time
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2018:
URL: https://github.com/apache/rocketmq/pull/2018#issuecomment-631655888
[](https://coveralls.io/builds/30925954)
Coverage increased (+0.01%) to 50.835% when pulling **a14cf634a56abefdec3cef7531d2b855dff1c939 on imaffe:affe-0520-fix-slotvalue** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org