You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@juneau.apache.org by ja...@apache.org on 2026/09/13 13:16:56 UTC
(juneau) 18/29: Drop dangling .work/specs/2026-08-18-console-credentials-surface.md references from two javadoc comments.
This is an automated email from the ASF dual-hosted git repository.
jamesbognar pushed a commit to branch juneau-release-manager
in repository https://gitbox.apache.org/repos/asf/juneau.git
commit 9860763538394131c81598f580a6a628bec4a774
Author: James Bognar <ja...@apache.org>
AuthorDate: Wed Aug 26 10:10:49 2026 -0400
Drop dangling .work/specs/2026-08-18-console-credentials-surface.md references from two javadoc comments.
That spec file no longer exists under .work/specs/ (only its README remains), so the
finding-id citations in GithubTokenValidatorTest's class javadoc (F2) and
CredentialWriteVectorTest's (F1) pointed at nothing. Both comments keep the substantive
finding they were citing -- gh's own output not reaching the message on either code path,
and the cross-origin form-encoded credential-overwrite vector -- and only drop the
now-broken pointer to the retired file.
---
.../juneau/releng/credential/GithubTokenValidatorTest.java | 3 +--
.../juneau/releng/rest/CredentialWriteVectorTest.java | 13 ++++++-------
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/src/test/java/org/apache/juneau/releng/credential/GithubTokenValidatorTest.java b/src/test/java/org/apache/juneau/releng/credential/GithubTokenValidatorTest.java
index d99556a323..ee98cea8b9 100644
--- a/src/test/java/org/apache/juneau/releng/credential/GithubTokenValidatorTest.java
+++ b/src/test/java/org/apache/juneau/releng/credential/GithubTokenValidatorTest.java
@@ -27,8 +27,7 @@ import org.junit.jupiter.api.Test;
/**
* {@link GithubTokenValidator}: the token travels by environment variable rather than argv, and {@code gh}'s own
- * output does not reach the message on either path (finding F2 of
- * {@code .work/specs/2026-08-18-console-credentials-surface.md}).
+ * output does not reach the message on either path.
*/
class GithubTokenValidatorTest {
diff --git a/src/test/java/org/apache/juneau/releng/rest/CredentialWriteVectorTest.java b/src/test/java/org/apache/juneau/releng/rest/CredentialWriteVectorTest.java
index a9c47cebaa..658f0b9ca0 100644
--- a/src/test/java/org/apache/juneau/releng/rest/CredentialWriteVectorTest.java
+++ b/src/test/java/org/apache/juneau/releng/rest/CredentialWriteVectorTest.java
@@ -41,13 +41,12 @@ import org.junit.jupiter.api.io.*;
* The credential-overwrite vector, reproduced and then closed.
*
* <p>
- * The finding this pins down (recorded as F1 in {@code .work/specs/2026-08-18-console-credentials-surface.md}) was
- * established by reading framework defaults rather than by issuing a request: {@code CredentialRest} extends
- * {@code BasicRestResource}, whose default parser list includes {@code UrlEncodingParser} and
- * {@code PlainTextParser}, and {@code disableContentParam} defaults to {@code false}. If that reading is right,
- * then a plain cross-origin {@code <form method="POST">} in any page the operator has open can replace a stored
- * credential — no JavaScript, and no CORS preflight, because form-encoded is one of the three content types a
- * browser may send cross-origin without one.
+ * The finding this pins down was established by reading framework defaults rather than by issuing a request:
+ * {@code CredentialRest} extends {@code BasicRestResource}, whose default parser list includes
+ * {@code UrlEncodingParser} and {@code PlainTextParser}, and {@code disableContentParam} defaults to
+ * {@code false}. If that reading is right, then a plain cross-origin {@code <form method="POST">} in any page the
+ * operator has open can replace a stored credential — no JavaScript, and no CORS preflight, because
+ * form-encoded is one of the three content types a browser may send cross-origin without one.
*
* <p>
* Group a reproduces it, and both of its routes are demonstrated as an <i>actual overwrite</i> — the claim is