You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Yukang-Lian (via GitHub)" <gi...@apache.org> on 2024/01/08 13:45:56 UTC
[PR] [Fix](core) Init wal manager show not core [doris]
Yukang-Lian opened a new pull request, #29688:
URL: https://github.com/apache/doris/pull/29688
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Update wal dir info show not core [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884251100
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Init wal manager show not core [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #29688:
URL: https://github.com/apache/doris/pull/29688#discussion_r1444677469
##########
be/src/olap/wal/wal_manager.cpp:
##########
@@ -97,67 +97,74 @@
if (std::filesystem::path(wal_dir).is_absolute()) {
tmp_dirs.emplace_back(wal_dir);
} else {
- return Status::InternalError(
- "BE config group_commit_replay_wal_dir has to be absolute path!");
+ LOG(WARNING) << "BE config group_commit_replay_wal_dir" << wal_dir
+ << "has to be absolute path!";
}
}
}
_wal_dirs = tmp_dirs;
- return Status::OK();
}
-Status WalManager::_init_wal_dirs() {
+void WalManager::_init_wal_dirs() {
Review Comment:
warning: method '_init_wal_dirs' can be made static [readability-convert-member-functions-to-static]
be/src/olap/wal/wal_manager.h:89:
```diff
- void _init_wal_dirs();
+ static void _init_wal_dirs();
```
##########
be/src/olap/wal/wal_manager.cpp:
##########
@@ -84,7 +84,7 @@ Status WalManager::init() {
&_replay_thread);
}
-Status WalManager::_init_wal_dirs_conf() {
+void WalManager::_init_wal_dirs_conf() {
Review Comment:
warning: method '_init_wal_dirs_conf' can be made static [readability-convert-member-functions-to-static]
be/src/olap/wal/wal_manager.h:88:
```diff
- void _init_wal_dirs_conf();
+ static void _init_wal_dirs_conf();
```
##########
be/src/olap/wal/wal_manager.cpp:
##########
@@ -97,67 +97,74 @@
if (std::filesystem::path(wal_dir).is_absolute()) {
tmp_dirs.emplace_back(wal_dir);
} else {
- return Status::InternalError(
- "BE config group_commit_replay_wal_dir has to be absolute path!");
+ LOG(WARNING) << "BE config group_commit_replay_wal_dir" << wal_dir
+ << "has to be absolute path!";
}
}
}
_wal_dirs = tmp_dirs;
- return Status::OK();
}
-Status WalManager::_init_wal_dirs() {
+void WalManager::_init_wal_dirs() {
bool exists = false;
for (auto wal_dir : _wal_dirs) {
std::string tmp_dir = wal_dir + "/" + _tmp;
LOG(INFO) << "wal_dir:" << wal_dir << ",tmp_dir:" << tmp_dir;
- RETURN_IF_ERROR(io::global_local_filesystem()->exists(wal_dir, &exists));
+ WARN_IF_ERROR(io::global_local_filesystem()->exists(wal_dir, &exists),
+ "check wal dir exists failed!");
if (!exists) {
- RETURN_IF_ERROR(io::global_local_filesystem()->create_directory(wal_dir));
+ WARN_IF_ERROR(io::global_local_filesystem()->create_directory(wal_dir),
+ "create wal dir failed!");
}
- RETURN_IF_ERROR(io::global_local_filesystem()->exists(tmp_dir, &exists));
+ WARN_IF_ERROR(io::global_local_filesystem()->exists(tmp_dir, &exists),
+ "check tmp dir exists failed!");
if (!exists) {
- RETURN_IF_ERROR(io::global_local_filesystem()->create_directory(tmp_dir));
+ WARN_IF_ERROR(io::global_local_filesystem()->create_directory(tmp_dir),
+ "create tmp dir failed!");
}
}
- return Status::OK();
}
-Status WalManager::_init_wal_dirs_info() {
+void WalManager::_init_wal_dirs_info() {
Review Comment:
warning: method '_init_wal_dirs_info' can be made static [readability-convert-member-functions-to-static]
be/src/olap/wal/wal_manager.h:90:
```diff
- void _init_wal_dirs_info();
+ static void _init_wal_dirs_info();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Update wal dir info show not core [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884118366
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Fix initializing the WalManager could prevent the BE from starting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884274751
TeamCity be ut coverage result:
Function Coverage: 36.66% (8645/23580)
Line Coverage: 28.71% (70427/245282)
Region Coverage: 27.64% (36380/131642)
Branch Coverage: 24.33% (18600/76448)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4878c93542207c6fd8f3f97bc8942c19cf3d1a2a_4878c93542207c6fd8f3f97bc8942c19cf3d1a2a/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Fix initializing the WalManager could prevent the BE from starting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884270159
<details>
<summary>TPC-H: <b>Total hot run time: 38850 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4878c93542207c6fd8f3f97bc8942c19cf3d1a2a, data reload: false
------ Round 1 ----------------------------------
q1 18088 5031 4978 4978
q2 2038 149 140 140
q3 10687 1140 1132 1132
q4 10249 804 812 804
q5 7823 3119 3211 3119
q6 204 124 127 124
q7 891 510 492 492
q8 9251 1973 2027 1973
q9 6627 6555 6472 6472
q10 8270 3108 3027 3027
q11 422 220 214 214
q12 358 195 195 195
q13 18118 3440 3403 3403
q14 245 216 209 209
q15 564 527 514 514
q16 433 408 391 391
q17 959 529 554 529
q18 7365 6796 6735 6735
q19 1562 1428 1395 1395
q20 483 319 296 296
q21 2785 2389 2463 2389
q22 359 319 332 319
Total cold run time: 107781 ms
Total hot run time: 38850 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5001 4971 4970 4970
q2 313 198 201 198
q3 3323 3315 3321 3315
q4 2273 2273 2274 2273
q5 5825 5808 5825 5808
q6 195 119 119 119
q7 2316 1852 1864 1852
q8 3476 3567 3566 3566
q9 8881 8867 8830 8830
q10 3764 3855 3854 3854
q11 551 437 419 419
q12 793 640 617 617
q13 3906 3241 3243 3241
q14 294 267 280 267
q15 562 511 514 511
q16 510 481 466 466
q17 2055 2058 2048 2048
q18 8693 8431 8316 8316
q19 1617 1596 1607 1596
q20 2152 1937 1923 1923
q21 6060 5710 5844 5710
q22 584 496 490 490
Total cold run time: 63144 ms
Total hot run time: 60389 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Init wal manager show not core [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1881089450
<details>
<summary>TPC-H: <b>Total hot run time: 38441 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit db9ad896b31615195013f3087978a5cb3f078b46, data reload: false
------ Round 1 ----------------------------------
q1 17723 4943 4904 4904
q2 2004 154 141 141
q3 10609 1143 1179 1143
q4 10476 804 724 724
q5 7805 2947 2957 2947
q6 205 129 128 128
q7 916 509 489 489
q8 9262 1954 2022 1954
q9 6413 6381 6328 6328
q10 8244 3023 2999 2999
q11 445 215 221 215
q12 386 235 235 235
q13 18000 3363 3377 3363
q14 235 213 206 206
q15 551 502 506 502
q16 446 392 394 392
q17 937 709 587 587
q18 7356 6724 6681 6681
q19 1542 1500 1500 1500
q20 737 312 312 312
q21 2767 2390 2426 2390
q22 370 301 327 301
Total cold run time: 107429 ms
Total hot run time: 38441 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4929 4894 4892 4892
q2 349 241 245 241
q3 3284 3291 3291 3291
q4 2095 2031 1991 1991
q5 5767 5778 5722 5722
q6 204 118 119 118
q7 2311 1911 1876 1876
q8 3374 3420 3458 3420
q9 8796 8728 8774 8728
q10 3792 3818 3811 3811
q11 562 438 438 438
q12 799 643 621 621
q13 5265 3232 3174 3174
q14 296 259 258 258
q15 538 501 508 501
q16 546 517 496 496
q17 1849 1863 1869 1863
q18 8645 8381 8409 8381
q19 1596 1635 1612 1612
q20 2176 1978 1987 1978
q21 5591 5183 5368 5183
q22 504 450 450 450
Total cold run time: 63268 ms
Total hot run time: 59045 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Fix initializing the WalManager could prevent the BE from starting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884288920
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 4878c93542207c6fd8f3f97bc8942c19cf3d1a2a with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 13.3 seconds inserted 10000000 Rows, about 751K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Fix initializing the WalManager could prevent the BE from starting [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #29688:
URL: https://github.com/apache/doris/pull/29688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Update wal dir info show not core [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1882554210
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Init wal manager show not core [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1881110609
<details>
<summary>TPC-DS: <b>Total hot run time: 184406 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit db9ad896b31615195013f3087978a5cb3f078b46, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 950 343 332 332
query2 6578 2000 1997 1997
query3 6713 228 224 224
query4 27089 22540 22444 22444
query5 4431 565 613 565
query6 324 211 194 194
query7 4630 311 311 311
query8 269 224 214 214
query9 8583 2890 2925 2890
query10 545 289 318 289
query11 15750 15798 15664 15664
query12 167 97 97 97
query13 1670 342 333 333
query14 12685 7641 7567 7567
query15 289 220 204 204
query16 6568 334 331 331
query17 1733 514 499 499
query18 2000 314 304 304
query19 235 168 161 161
query20 108 100 103 100
query21 189 100 94 94
query22 5157 4994 4955 4955
query23 32401 31507 31488 31488
query24 12018 2963 2946 2946
query25 606 359 360 359
query26 1848 179 175 175
query27 2772 320 318 318
query28 7185 2145 2109 2109
query29 2091 412 396 396
query30 284 145 151 145
query31 1046 829 827 827
query32 131 88 83 83
query33 848 341 341 341
query34 815 483 470 470
query35 968 858 876 858
query36 1400 1222 1283 1222
query37 215 92 83 83
query38 3535 3450 3416 3416
query39 1358 1328 1324 1324
query40 302 95 90 90
query41 39 39 38 38
query42 123 103 113 103
query43 598 558 529 529
query44 1198 803 805 803
query45 219 199 197 197
query46 1069 679 732 679
query47 1705 1637 1623 1623
query48 367 291 312 291
query49 1217 318 319 318
query50 740 326 325 325
query51 5343 5405 5317 5317
query52 111 95 97 95
query53 229 167 162 162
query54 1429 680 682 680
query55 110 99 95 95
query56 282 245 231 231
query57 1082 989 979 979
query58 316 276 289 276
query59 3090 2779 2872 2779
query60 320 296 293 293
query61 150 150 147 147
query62 590 486 495 486
query63 199 182 182 182
query64 5827 1752 1741 1741
query65 3414 3353 3340 3340
query66 1461 420 393 393
query67 15578 15115 15325 15115
query68 11355 558 569 558
query69 603 334 326 326
query70 1757 1585 1619 1585
query71 602 308 293 293
query72 5330 3400 3430 3400
query73 2141 340 333 333
query74 7058 6520 6604 6520
query75 4864 2341 2302 2302
query76 6395 1112 1249 1112
query77 771 342 316 316
query78 9111 8666 8575 8575
query79 1051 527 540 527
query80 550 349 349 349
query81 463 212 215 212
query82 231 100 103 100
query83 167 150 140 140
query84 254 57 57 57
query85 891 294 263 263
query86 431 449 441 441
query87 3673 3505 3415 3415
query88 3217 2504 2536 2504
query89 360 279 293 279
query90 1996 254 251 251
query91 123 95 97 95
query92 90 79 69 69
query93 1100 442 486 442
query94 843 246 228 228
query95 589 508 484 484
query96 653 343 341 341
query97 4395 4184 4216 4184
query98 238 223 222 222
query99 1192 847 847 847
Total cold run time: 295786 ms
Total hot run time: 184406 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Fix initializing the WalManager could prevent the BE from starting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884280999
<details>
<summary>TPC-DS: <b>Total hot run time: 178659 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4878c93542207c6fd8f3f97bc8942c19cf3d1a2a, data reload: false
query1 949 348 335 335
query2 6687 1924 1901 1901
query3 6699 225 212 212
query4 26019 22308 22154 22154
query5 5512 540 500 500
query6 279 191 186 186
query7 4611 283 279 279
query8 247 218 208 208
query9 9148 2831 2867 2831
query10 476 252 244 244
query11 16137 15313 15346 15313
query12 138 82 77 77
query13 1633 355 356 355
query14 11925 7556 7442 7442
query15 240 192 197 192
query16 6411 281 269 269
query17 1873 496 482 482
query18 1937 293 278 278
query19 301 152 148 148
query20 84 83 78 78
query21 187 97 93 93
query22 5155 4898 4772 4772
query23 32331 31486 31131 31131
query24 12416 2893 2833 2833
query25 585 360 355 355
query26 1747 153 162 153
query27 2864 280 275 275
query28 7172 1893 1891 1891
query29 2111 397 406 397
query30 294 145 150 145
query31 981 780 774 774
query32 92 66 60 60
query33 741 276 281 276
query34 976 451 449 449
query35 898 764 747 747
query36 1455 1274 1217 1217
query37 195 69 73 69
query38 3396 3301 3279 3279
query39 1343 1303 1308 1303
query40 324 103 89 89
query41 42 35 36 35
query42 101 96 99 96
query43 539 508 504 504
query44 1191 709 731 709
query45 214 191 191 191
query46 1062 679 678 678
query47 1649 1625 1642 1625
query48 400 311 326 311
query49 1261 323 317 317
query50 736 342 328 328
query51 5327 5310 5296 5296
query52 101 88 93 88
query53 221 151 155 151
query54 1426 582 605 582
query55 102 98 95 95
query56 233 210 205 205
query57 996 918 963 918
query58 243 217 216 216
query59 2815 2503 2522 2503
query60 254 232 266 232
query61 92 89 85 85
query62 647 477 456 456
query63 175 155 155 155
query64 5975 1663 1693 1663
query65 3384 3248 3255 3248
query66 1336 339 336 336
query67 15727 14831 15433 14831
query68 12465 533 538 533
query69 571 275 280 275
query70 1743 1577 1578 1577
query71 499 232 217 217
query72 4923 2879 2857 2857
query73 2706 320 320 320
query74 6948 6425 6424 6424
query75 5072 2291 2284 2284
query76 6334 894 1092 894
query77 683 282 293 282
query78 9737 8681 8458 8458
query79 1041 528 496 496
query80 579 358 353 353
query81 458 220 237 220
query82 212 88 87 87
query83 162 142 141 141
query84 276 58 58 58
query85 969 301 304 301
query86 379 371 358 358
query87 3569 3455 3387 3387
query88 3226 2309 2329 2309
query89 349 266 260 260
query90 1874 222 199 199
query91 172 136 142 136
query92 64 57 55 55
query93 1228 428 426 426
query94 874 191 192 191
query95 483 424 421 421
query96 639 327 340 327
query97 4295 4197 4156 4156
query98 196 199 186 186
query99 1111 869 825 825
Total cold run time: 296655 ms
Total hot run time: 178659 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Init wal manager show not core [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1882546800
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Update wal dir info show not core [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1882581694
TeamCity be ut coverage result:
Function Coverage: 36.64% (8639/23580)
Line Coverage: 28.66% (70222/245052)
Region Coverage: 27.60% (36313/131570)
Branch Coverage: 24.29% (18556/76396)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8fb066b85b4ecef768b7557d433827c8a06de916_8fb066b85b4ecef768b7557d433827c8a06de916/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Fix initializing the WalManager could prevent the BE from starting [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884866230
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Init wal manager show not core [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1881124476
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.03 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 27.7 seconds inserted 10000000 Rows, about 361K ops/s
storage size: 17184273699 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Update wal dir info show not core [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884121846
Is there a typo in pr title `Update wal dir info should not core`?
And better to add more description, this pr is fix that init wal_manager should not cause be can not start when update wal dir info error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Fix initializing the WalManager could prevent the BE from starting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884286086
<details>
<summary>ClickBench: <b>Total hot run time: 30.62 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4878c93542207c6fd8f3f97bc8942c19cf3d1a2a, data reload: false
query1 0.06 0.06 0.05
query2 0.06 0.02 0.02
query3 0.26 0.12 0.12
query4 1.74 0.13 0.12
query5 0.51 0.52 0.52
query6 1.38 0.63 0.63
query7 0.02 0.01 0.02
query8 0.03 0.02 0.02
query9 0.57 0.50 0.50
query10 0.54 0.54 0.54
query11 0.13 0.09 0.09
query12 0.11 0.10 0.09
query13 0.60 0.59 0.59
query14 0.77 0.81 0.76
query15 0.82 0.81 0.80
query16 0.35 0.36 0.34
query17 0.98 1.00 0.98
query18 0.25 0.25 0.25
query19 1.83 1.74 1.80
query20 0.01 0.01 0.01
query21 15.41 0.57 0.56
query22 2.77 2.13 2.34
query23 17.40 0.97 0.86
query24 2.53 3.71 0.33
query25 1.76 0.16 0.15
query26 0.13 0.14 0.13
query27 0.15 0.15 0.15
query28 10.29 0.84 0.81
query29 12.70 3.31 3.22
query30 0.53 0.47 0.48
query31 2.78 0.35 0.36
query32 3.36 0.48 0.48
query33 3.19 3.23 3.19
query34 16.03 4.21 4.19
query35 4.20 4.16 4.13
query36 1.10 1.04 1.05
query37 0.07 0.05 0.05
query38 0.03 0.03 0.03
query39 0.03 0.02 0.01
query40 0.16 0.12 0.12
query41 0.08 0.02 0.01
query42 0.02 0.01 0.02
query43 0.03 0.02 0.02
Total cold run time: 105.77 s
Total hot run time: 30.62 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Fix initializing the WalManager could prevent the BE from starting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884290701
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.49 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 21.7 seconds inserted 10000000 Rows, about 460K ops/s
storage size: 17184217644 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Init wal manager show not core [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1881038292
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Update wal dir info show not core [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1882571470
<details>
<summary>TPC-H: <b>Total hot run time: 38254 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8fb066b85b4ecef768b7557d433827c8a06de916, data reload: false
------ Round 1 ----------------------------------
q1 17687 4974 4930 4930
q2 2018 152 141 141
q3 10584 1107 1116 1107
q4 10197 781 783 781
q5 7778 2946 2872 2872
q6 201 123 121 121
q7 900 530 490 490
q8 9241 1952 1978 1952
q9 6435 6372 6306 6306
q10 8212 3001 3068 3001
q11 428 223 218 218
q12 385 225 229 225
q13 18012 3358 3393 3358
q14 246 202 211 202
q15 543 507 503 503
q16 441 383 397 383
q17 943 722 602 602
q18 7240 6635 6644 6635
q19 1577 1517 1504 1504
q20 679 310 303 303
q21 2692 2331 2328 2328
q22 346 292 315 292
Total cold run time: 106785 ms
Total hot run time: 38254 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4885 4888 4924 4888
q2 335 230 242 230
q3 3268 3297 3282 3282
q4 2125 2028 1995 1995
q5 5756 5775 5780 5775
q6 206 118 119 118
q7 2328 1910 1916 1910
q8 3328 3423 3443 3423
q9 8771 8706 8693 8693
q10 3768 3825 3830 3825
q11 533 431 434 431
q12 795 622 643 622
q13 7135 3169 3161 3161
q14 295 257 282 257
q15 544 503 496 496
q16 529 484 489 484
q17 1878 1862 1847 1847
q18 8512 8447 8292 8292
q19 1574 1609 1610 1609
q20 2167 1958 1923 1923
q21 5545 5172 5219 5172
q22 498 474 456 456
Total cold run time: 64775 ms
Total hot run time: 58889 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Update wal dir info show not core [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1882586401
<details>
<summary>TPC-DS: <b>Total hot run time: 183443 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8fb066b85b4ecef768b7557d433827c8a06de916, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 946 344 331 331
query2 6559 1982 2035 1982
query3 6803 234 223 223
query4 27473 22332 22356 22332
query5 6114 572 585 572
query6 326 211 202 202
query7 4623 294 299 294
query8 260 233 220 220
query9 8721 2901 2879 2879
query10 595 329 332 329
query11 16271 15627 15581 15581
query12 166 103 100 100
query13 1662 332 364 332
query14 12786 7586 7596 7586
query15 262 220 207 207
query16 6368 333 330 330
query17 1722 534 502 502
query18 1959 294 297 294
query19 239 163 159 159
query20 109 101 106 101
query21 185 100 93 93
query22 5046 4625 4801 4625
query23 32441 31279 31291 31279
query24 12146 2926 2919 2919
query25 594 364 369 364
query26 1826 166 178 166
query27 3079 317 304 304
query28 6940 2106 2104 2104
query29 2067 423 403 403
query30 298 142 143 142
query31 1026 795 824 795
query32 134 76 82 76
query33 829 349 341 341
query34 852 474 483 474
query35 989 900 874 874
query36 1429 1247 1250 1247
query37 204 84 83 83
query38 3495 3354 3354 3354
query39 1352 1319 1330 1319
query40 307 92 86 86
query41 39 36 38 36
query42 110 102 111 102
query43 562 521 519 519
query44 1254 806 803 803
query45 221 198 205 198
query46 1050 693 743 693
query47 1734 1665 1708 1665
query48 361 288 289 288
query49 1205 310 304 304
query50 744 324 337 324
query51 5440 5258 5274 5258
query52 101 101 96 96
query53 234 172 171 171
query54 1434 679 671 671
query55 118 94 103 94
query56 268 235 245 235
query57 1051 1044 982 982
query58 315 280 284 280
query59 3137 2959 3064 2959
query60 355 293 261 261
query61 152 151 156 151
query62 598 466 531 466
query63 197 168 183 168
query64 6024 1698 1652 1652
query65 3418 3315 3347 3315
query66 1322 383 378 378
query67 15415 15022 15459 15022
query68 12935 543 543 543
query69 649 326 299 299
query70 1762 1619 1542 1542
query71 618 286 255 255
query72 5316 3442 3480 3442
query73 2901 346 334 334
query74 7055 6504 6528 6504
query75 5249 2277 2280 2277
query76 6344 1174 1196 1174
query77 759 312 309 309
query78 9093 8510 8538 8510
query79 1069 532 545 532
query80 614 346 340 340
query81 463 208 209 208
query82 237 100 106 100
query83 189 140 141 140
query84 252 58 56 56
query85 950 292 263 263
query86 423 436 405 405
query87 3634 3483 3480 3480
query88 3155 2496 2529 2496
query89 382 275 278 275
query90 1914 262 264 262
query91 123 92 96 92
query92 95 69 78 69
query93 1135 500 479 479
query94 859 240 240 240
query95 569 493 498 493
query96 645 341 339 339
query97 4374 4230 4321 4230
query98 245 220 221 220
query99 1181 840 898 840
Total cold run time: 301251 ms
Total hot run time: 183443 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Update wal dir info show not core [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1882582640
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.01 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 27.4 seconds inserted 10000000 Rows, about 364K ops/s
storage size: 17184128717 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](core) Fix initializing the WalManager could prevent the BE from starting [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29688:
URL: https://github.com/apache/doris/pull/29688#issuecomment-1884256937
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org