You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <me...@freestoneinfotech.com> on 2017/02/28 13:22:42 UTC
Review Request 57086: RANGER-1405 : groups are not shown if exact
user name is passed in search filter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57086/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-1405
https://issues.apache.org/jira/browse/RANGER-1405
Repository: ranger
Description
-------
Groups are not shown if exact user name is passed in search filter. Reason behind that is that, results are sorted by Id and due to that only first page's results are returned.
Expected Behaviour:
In Search criteria, if exact result is found then user / group of that needs to be shown first.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 9139b95
security-admin/src/main/webapp/scripts/modules/XAOverrides.js 94ab1c2
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 6221149
security-admin/src/main/webapp/scripts/views/users/GroupCreate.js f915468
security-admin/src/main/webapp/scripts/views/users/UserCreate.js 46eff6d
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4b1b036
Diff: https://reviews.apache.org/r/57086/diff/
Testing
-------
Verified :
1) Verified user search on UI for exact search as well as partial search on User Listing page.
2) Verified search by multiple criterias on User Listing page.
3) Verified same search criterias by REST APIs as well.
Thanks,
Mehul Parikh
Re: Review Request 57086: RANGER-1405 : groups are not shown if exact
user name is passed in search filter
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57086/#review167273
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Feb. 28, 2017, 1:22 p.m., Mehul Parikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57086/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 1:22 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1405
> https://issues.apache.org/jira/browse/RANGER-1405
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Groups are not shown if exact user name is passed in search filter. Reason behind that is that, results are sorted by Id and due to that only first page's results are returned.
>
> Expected Behaviour:
> In Search criteria, if exact result is found then user / group of that needs to be shown first.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 9139b95
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 94ab1c2
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 6221149
> security-admin/src/main/webapp/scripts/views/users/GroupCreate.js f915468
> security-admin/src/main/webapp/scripts/views/users/UserCreate.js 46eff6d
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4b1b036
>
>
> Diff: https://reviews.apache.org/r/57086/diff/1/
>
>
> Testing
> -------
>
> Verified :
> 1) Verified user search on UI for exact search as well as partial search on User Listing page.
> 2) Verified search by multiple criterias on User Listing page.
> 3) Verified same search criterias by REST APIs as well.
>
>
> Thanks,
>
> Mehul Parikh
>
>
Re: Review Request 57086: RANGER-1405 : groups are not shown if exact
user name is passed in search filter
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57086/#review168239
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On March 7, 2017, 5:28 a.m., Mehul Parikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57086/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 5:28 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1405
> https://issues.apache.org/jira/browse/RANGER-1405
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Groups are not shown if exact user name is passed in search filter. Reason behind that is that, results are sorted by Id and due to that only first page's results are returned.
>
> Expected Behaviour:
> In Search criteria, if exact result is found then user / group of that needs to be shown first.
>
>
> Diffs
> -----
>
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java f657795
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 62cffa5
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 94ab1c2
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 6221149
> security-admin/src/main/webapp/scripts/views/users/GroupCreate.js f915468
> security-admin/src/main/webapp/scripts/views/users/UserCreate.js 46eff6d
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4b1b036
>
>
> Diff: https://reviews.apache.org/r/57086/diff/2/
>
>
> Testing
> -------
>
> Verified :
> 1) Verified user search on UI for exact search as well as partial search on User Listing page.
> 2) Verified search by multiple criterias on User Listing page.
> 3) Verified same search criterias by REST APIs as well.
>
>
> Thanks,
>
> Mehul Parikh
>
>
Re: Review Request 57086: RANGER-1405 : groups are not shown if exact
user name is passed in search filter
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57086/
-----------------------------------------------------------
(Updated March 7, 2017, 5:28 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-1405
https://issues.apache.org/jira/browse/RANGER-1405
Repository: ranger
Description
-------
Groups are not shown if exact user name is passed in search filter. Reason behind that is that, results are sorted by Id and due to that only first page's results are returned.
Expected Behaviour:
In Search criteria, if exact result is found then user / group of that needs to be shown first.
Diffs (updated)
-----
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java f657795
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 62cffa5
security-admin/src/main/webapp/scripts/modules/XAOverrides.js 94ab1c2
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 6221149
security-admin/src/main/webapp/scripts/views/users/GroupCreate.js f915468
security-admin/src/main/webapp/scripts/views/users/UserCreate.js 46eff6d
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4b1b036
Diff: https://reviews.apache.org/r/57086/diff/2/
Changes: https://reviews.apache.org/r/57086/diff/1-2/
Testing
-------
Verified :
1) Verified user search on UI for exact search as well as partial search on User Listing page.
2) Verified search by multiple criterias on User Listing page.
3) Verified same search criterias by REST APIs as well.
Thanks,
Mehul Parikh
Re: Review Request 57086: RANGER-1405 : groups are not shown if exact
user name is passed in search filter
Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57086/#review167794
-----------------------------------------------------------
Ship it!
Ship It!
- Ankita Sinha
On Feb. 28, 2017, 1:22 p.m., Mehul Parikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57086/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 1:22 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1405
> https://issues.apache.org/jira/browse/RANGER-1405
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Groups are not shown if exact user name is passed in search filter. Reason behind that is that, results are sorted by Id and due to that only first page's results are returned.
>
> Expected Behaviour:
> In Search criteria, if exact result is found then user / group of that needs to be shown first.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 9139b95
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 94ab1c2
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 6221149
> security-admin/src/main/webapp/scripts/views/users/GroupCreate.js f915468
> security-admin/src/main/webapp/scripts/views/users/UserCreate.js 46eff6d
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4b1b036
>
>
> Diff: https://reviews.apache.org/r/57086/diff/1/
>
>
> Testing
> -------
>
> Verified :
> 1) Verified user search on UI for exact search as well as partial search on User Listing page.
> 2) Verified search by multiple criterias on User Listing page.
> 3) Verified same search criterias by REST APIs as well.
>
>
> Thanks,
>
> Mehul Parikh
>
>