You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2016/08/09 23:23:57 UTC
[jclouds/jclouds] Always take into account the configured template
builder spec in live tests (#993)
@ivanlomba Can you cherry-pick this commit into your branch, compile it, and try running the live tests for GCE? Run all the tests, not just a single one to make sure all maven configuration for the live profile is properly applied.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/993
-- Commit Summary --
* Always take into account the configured template builder spec when building a template in live tests
-- File Changes --
M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/FirewallApiLiveTest.java (2)
M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/LoadBalancerApiLiveTest.java (2)
M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/SecurityGroupApiLiveTest.java (4)
M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/TemplateApiLiveTest.java (2)
M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/VirtualMachineApiLiveTest.java (4)
M apis/cloudstack/src/test/java/org/jclouds/cloudstack/functions/StaticNATVirtualMachineInNetworkLiveTest.java (2)
M compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java (26)
M compute/src/test/java/org/jclouds/compute/internal/BaseGenericComputeServiceContextLiveTest.java (12)
M compute/src/test/java/org/jclouds/compute/internal/BaseTemplateBuilderLiveTest.java (6)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/993.patch
https://github.com/jclouds/jclouds/pull/993.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/993
Re: [jclouds/jclouds] Always take into account the configured
template builder spec in live tests (#993)
Posted by Ignasi Barrera <no...@github.com>.
I've run the tests in several providers and the fix works fine.
Amended the formatting thing, rebased and merged to master as [449c6d8d](http://git-wip-us.apache.org/repos/asf/jclouds/commit/449c6d8d). Thanks @ivanlomba and @demobox!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/993#issuecomment-239313063
Re: [jclouds/jclouds] Always take into account the configured
template builder spec in live tests (#993)
Posted by Andrew Phillips <no...@github.com>.
> Yes. The base class for the compute service live tests was ignoring the "template" test property in some tests, so even when configured in the pom.xml or as system property, a default template was used instead of the configured one.
Ah, OK - thanks for explaining!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/993#issuecomment-239098128
Re: [jclouds/jclouds] Always take into account the configured
template builder spec in live tests (#993)
Posted by Andrew Phillips <no...@github.com>.
> @@ -524,6 +524,14 @@ protected void checkNodes(Iterable<? extends NodeMetadata> nodes, String group,
> }
> }
>
> + protected TemplateBuilder templateBuilder() {
> + TemplateBuilder templateBuilder = client.templateBuilder();
[formatting] Double space here
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/993/files/80ec2aa632dd5bc2ccf6abcc10745eecc3df0363#r74363539
Re: [jclouds/jclouds] Always take into account the configured
template builder spec in live tests (#993)
Posted by Ignasi Barrera <no...@github.com>.
Yes. The base class for the compute service live tests was ignoring the "template" test property in some tests, so even when configured in the pom.xml or as system property, a default template was used instead of the configured one.
This lead to some tests failing to connect via SSH if the template builder picked a windows machine, etc.
I still want to run the tests in a couple more providers before merging it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/993#issuecomment-239096007
Re: [jclouds/jclouds] Always take into account the configured
template builder spec in live tests (#993)
Posted by Ignasi Barrera <no...@github.com>.
Closed #993.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/993#event-753356726
Re: [jclouds/jclouds] Always take into account the configured
template builder spec in live tests (#993)
Posted by Iván Lomba <no...@github.com>.
Thanks : )
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/993#issuecomment-238978718
Re: [jclouds/jclouds] Always take into account the configured
template builder spec in live tests (#993)
Posted by Andrew Phillips <no...@github.com>.
@nacx @ivanlomba Just to confirm: this commit is only about the *tests*, correct?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/993#issuecomment-239061181