You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/12 11:19:59 UTC
[GitHub] [tvm] echuraev opened a new pull request, #12401: [HotFix] Op is not bound to any variables
echuraev opened a new pull request, #12401:
URL: https://github.com/apache/tvm/pull/12401
After PR #12349 inference of some Adreno networks was broken. In the
output it was the following error:
```
TVMError: Not all Vars are passed in api_args: 'compute' is not bound
to any variables
```
cc: @tkonolige, @Lunderberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on a diff in pull request #12401: [HotFix] Op is not bound to any variables
Posted by GitBox <gi...@apache.org>.
echuraev commented on code in PR #12401:
URL: https://github.com/apache/tvm/pull/12401#discussion_r944636156
##########
src/tir/transforms/storage_rewrite.cc:
##########
@@ -1463,7 +1463,9 @@ class VectorTypeRewriter : public StmtExprMutator {
Stmt VisitStmt_(const LetStmtNode* op) final {
auto it = rewrite_map_.find(op->var.get());
- if (it == rewrite_map_.end()) {
+ PrimExpr value = this->VisitExpr(op->value);
+ Stmt body = this->VisitStmt(op->body);
+ if (value.same_as(op->value) && body.same_as(op->body) && it == rewrite_map_.end()) {
Review Comment:
Done. Thank you @Lunderberg for your help! We will enable OpenCL tests in the CI to cover this OpenCL specific case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] csullivan merged pull request #12401: [HotFix] Op is not bound to any variables
Posted by GitBox <gi...@apache.org>.
csullivan merged PR #12401:
URL: https://github.com/apache/tvm/pull/12401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a diff in pull request #12401: [HotFix] Op is not bound to any variables
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on code in PR #12401:
URL: https://github.com/apache/tvm/pull/12401#discussion_r944462931
##########
src/tir/transforms/storage_rewrite.cc:
##########
@@ -1463,7 +1463,9 @@ class VectorTypeRewriter : public StmtExprMutator {
Stmt VisitStmt_(const LetStmtNode* op) final {
auto it = rewrite_map_.find(op->var.get());
- if (it == rewrite_map_.end()) {
+ PrimExpr value = this->VisitExpr(op->value);
+ Stmt body = this->VisitStmt(op->body);
+ if (value.same_as(op->value) && body.same_as(op->body) && it == rewrite_map_.end()) {
Review Comment:
Hmm, I'm not seeing where either `value` or `body` get returned. Also, it looks like we'd have an error if the `body` gets modified, but `op->var` isn't in `rewrite_map_`, which would result in unprotected dereferencing of `it->second`. Could we instead have something like the following, so that the var/value/body are all handled in a similar way?
```
PrimExpr value = this->VisitExpr(op->value);
Stmt body = this->VisitStmt(op->body);
Var var = (it == rewrite_map_.end()) ? op-> var : it->second.new_buffer_var;
if(var.same_as(op->var) && value.same_as(op->value) && body.same_as(op->body)) {
return GetRef<Stmt>(op);
} else {
return LetStmt(var, value, body);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] csullivan commented on pull request #12401: [HotFix] Op is not bound to any variables
Posted by GitBox <gi...@apache.org>.
csullivan commented on PR #12401:
URL: https://github.com/apache/tvm/pull/12401#issuecomment-1216823522
Thanks @echuraev @Lunderberg for the great follow up. This is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org