You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 13:23:02 UTC

[GitHub] [arrow-rs] ovr opened a new pull request, #2067: feat(compute): Support doy (day of year) for temporal

ovr opened a new pull request, #2067:
URL: https://github.com/apache/arrow-rs/pull/2067

   # Rationale for this change
   
   DataFusion uses temporal to operate with date like structures. I want to implement `EXTRACT(DOY from NOW())`.
   
   # What changes are included in this PR?
   
   Implementation of temporal::doy
   
   # Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ursabot commented on pull request #2067: feat(compute): Support doy (day of year) for temporal

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2067:
URL: https://github.com/apache/arrow-rs/pull/2067#issuecomment-1187835174

   Benchmark runs are scheduled for baseline = 7b3d0628859fa9349522a0e3274e5011cf2a8b06 and contender = 6a37d9f5ff69be0d5c8d73300e79e08c93803df1. 6a37d9f5ff69be0d5c8d73300e79e08c93803df1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e70e2150ca1d40bbbb569655bdf520cf...3a5d05ebdcc64bfba00f979e10c61ebb/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/72e794561942410b960b104869e15008...6ac8a608f5774c419607c057b5fd4c5f/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8fb9d5826b9d4d34997bfcbe6686b1fb...0c551c4765214061b3586a98a6acd022/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7e2fbcbf9f924d289b62ce87ca8368d6...e29db4c83abd4db985f0df59213a2918/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2067: feat(compute): Support doy (day of year) for temporal

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2067:
URL: https://github.com/apache/arrow-rs/pull/2067#discussion_r922706303


##########
arrow/src/compute/kernels/temporal.rs:
##########
@@ -338,7 +338,7 @@ where
                 scratch
             )
         }
-        dt => return_compute_error_with!("weekday does not support", dt),
+        dt => return_compute_error_with!("weekday0 does not support", dt),

Review Comment:
   This function is now called `num_days_from_sunday`
   ```suggestion
           dt => return_compute_error_with!("num_days_from_sunday does not support", dt),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #2067: feat(compute): Support doy (day of year) for temporal

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2067:
URL: https://github.com/apache/arrow-rs/pull/2067


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] codecov-commenter commented on pull request #2067: feat(compute): Support doy (day of year) for temporal

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2067:
URL: https://github.com/apache/arrow-rs/pull/2067#issuecomment-1184485898

   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2067](https://codecov.io/gh/apache/arrow-rs/pull/2067?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92b1aca) into [master](https://codecov.io/gh/apache/arrow-rs/commit/4444cb70607a9f0fe4c0f4130fa03b34faffef9c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4444cb7) will **decrease** coverage by `0.00%`.
   > The diff coverage is `76.19%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2067      +/-   ##
   ==========================================
   - Coverage   83.57%   83.56%   -0.01%     
   ==========================================
     Files         222      222              
     Lines       58244    58264      +20     
   ==========================================
   + Hits        48675    48690      +15     
   - Misses       9569     9574       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [arrow/src/compute/kernels/temporal.rs](https://codecov.io/gh/apache/arrow-rs/pull/2067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy90ZW1wb3JhbC5ycw==) | `94.10% <76.19%> (-0.89%)` | :arrow_down: |
   | [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/2067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.43% <0.00%> (-0.20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2067?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2067?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4444cb7...92b1aca](https://codecov.io/gh/apache/arrow-rs/pull/2067?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ovr commented on a diff in pull request #2067: feat(compute): Support doy (day of year) for temporal

Posted by GitBox <gi...@apache.org>.
ovr commented on code in PR #2067:
URL: https://github.com/apache/arrow-rs/pull/2067#discussion_r923237392


##########
arrow/src/compute/kernels/temporal.rs:
##########
@@ -338,7 +338,7 @@ where
                 scratch
             )
         }
-        dt => return_compute_error_with!("weekday does not support", dt),
+        dt => return_compute_error_with!("weekday0 does not support", dt),

Review Comment:
   Ty



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org