You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2014/10/04 22:18:43 UTC

[GitHub] couchdb-fauxton pull request: Creating new View when on View Metad...

GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/79

    Creating new View when on View Metadata page doubles up page content

    Simple fix for issue: https://issues.apache.org/jira/browse/COUCHDB-2349

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton 2349-new-view-page-double-content

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #79
    
----
commit ca1ca22f55ca7c3605467b64235ad1473ff2cf5e
Author: Benjamin Keen <be...@gmail.com>
Date:   2014-10-04T20:14:38Z

    Creating new View when on View Metadata page doubles up page content

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Creating new View when on View Metad...

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/79#issuecomment-58860222
  
    works like a charm! thank you @benkeen! merged as d339a463c3bf63cd71b2b68a0c54caa644eecf3b


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Creating new View when on View Metad...

Posted by benkeen <gi...@git.apache.org>.

Github user benkeen closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/79


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Creating new View when on View Metad...

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/79#issuecomment-57992728
  
    Hi @benkeen, 
    
    Unfortunately this fix isn't quite right. By just clearing the dom and not removing the view then `DdocInfo` view is still around and the interval timer will still be running. Instead what would be better is to get backbone.layoutmanager to remove the view for us. That needs a little plumbing.
    
    You need to create a `removeView` method [here](https://github.com/apache/couchdb-fauxton/blob/master/app/core/routeObject.js#L236). The method should do this but with some more error checking:
    
        removeView: function (selector) {
          this.views[selector].remove();
          this.views[selector] = null;
        },
    
    Then in `routes-documents`, instead of doing `$("#dashboard-lower-content").html("");` we can just do `this.removeView('#dashboard-lower-content');` and everything gets nicely cleaned up and garbage collected.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Creating new View when on View Metad...

Posted by benkeen <gi...@git.apache.org>.

Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/79#issuecomment-58019370
  
    Ah, of course! Sorry - I should have realized that. Will fix shortly. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---