[jira] Updated: (MIME4J-93) The use of RootInputStream degrades performance by 50%

["Markus Wiederkehr (JIRA)" <mi...@james.apache.org>]

     [ https://issues.apache.org/jira/browse/MIME4J-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Markus Wiederkehr updated MIME4J-93:
------------------------------------

    Attachment: mime4j-optional-linenumbers-part1.patch

This patch renames RootInputStream in LineNumberInputStream and also makes it optional.

The patch does not handle the stream truncation. There is a FIXME in MimeTokenStream.stop().. Strangely the unit tests pass nevertheless.

@Oleg: can you take over from here? I'm not sure how you wanted to handle the stream truncation..

> The use of RootInputStream degrades performance by 50%
> ------------------------------------------------------
>
>                 Key: MIME4J-93
>                 URL: https://issues.apache.org/jira/browse/MIME4J-93
>             Project: JAMES Mime4j
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Oleg Kalnichevski
>             Fix For: 0.6
>
>         Attachments: mime4j-optional-linenumbers-part1.patch
>
>
> I have never been a big fan of RootInputStream, because it simply does not work correctly for messages with binary coded parts. Please consider making RootInputStream optional, so one could eliminate it from the input filer chain entirely or disable line counting. This should result in a noticeable performance boost (up to 50%)
> Oleg

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.