You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2023/04/29 03:07:29 UTC
[GitHub] [druid] clintropolis opened a new pull request, #14186: fix bugs with auto encoded long vector deserializers
clintropolis opened a new pull request, #14186:
URL: https://github.com/apache/druid/pull/14186
### Description
This PR fixes an issue when using 'auto' encoded `LONG` typed columns and the 'vectorized' query engine. These columns use a delta based bit-packing mechanism, and errors in the vectorized reader would cause it to incorrectly read column values for some bit sizes. This is a regression caused by #11004, which added the optimized readers to improve performance.
While writing the test I finally got sad enough about `IndexSpec` not having a "builder", so I made one, and switched all the things to use it. Apologies for the noise in this bug fix PR, the only real changes are in `VSizeLongSerde`, and the tests that have been modified to cover the buggy behavior, `VSizeLongSerdeTest` and `ExpressionVectorSelectorsTest`. Everything else is just cleanup of `IndexSpec` usage.
#### Release note
'auto' encoded `LONG` typed columns can read values incorrectly when using the vectorized query engine. The data itself in the segment is fine, it is just translated incorrectly for the vectorize query engine. If using 'auto' encoded `LONG` columns we recommended to disable vectorization until upgrading to a Druid version which contains this fix
<hr>
##### Key changed/added classes in this PR
* `VSizeLongSerde`
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #14186: fix bugs with auto encoded long vector deserializers
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #14186:
URL: https://github.com/apache/druid/pull/14186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org