[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24018: [SPARK-23749][SQL] Workaround built-in Hive api changes (phase 1)

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24018: [SPARK-23749][SQL] Workaround built-in Hive api changes (phase 1)
URL: https://github.com/apache/spark/pull/24018#discussion_r264056156
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala
 ##########
 @@ -195,6 +199,15 @@ class OrcFileFormat extends FileFormat with DataSourceRegister with Serializable
 
     case _ => false
   }
+
+  // HIVE-11253 removed toKryo(). Adapted it from Hive 1.2's SearchArgumentImpl.toKryo().
 
 Review comment:
   nit. The following will be more accurate.
   ```
   HIVE-11253 moved `toKryo` from `SearchArgument` to `storage-api` module. This is copied from ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org