You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2020/06/15 02:44:14 UTC

[hbase] branch master updated: HBASE-24517 Addendum add more comments (#1882)

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new d0f190b  HBASE-24517 Addendum add more comments (#1882)
d0f190b is described below

commit d0f190bdf059c73a79567bd1c41129d1f5306cb2
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Mon Jun 15 10:43:57 2020 +0800

    HBASE-24517 Addendum add more comments (#1882)
    
    Signed-off-by: Jan Hentschel <ja...@ultratendency.com>
    Signed-off-by: Viraj Jasani <vj...@apache.org>
---
 .../org/apache/hadoop/hbase/master/assignment/AssignmentManager.java   | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
index b17693b..71cb47b 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
@@ -228,6 +228,9 @@ public class AssignmentManager {
     ZKWatcher zkw = master.getZooKeeper();
     // it could be null in some tests
     if (zkw != null) {
+      // here we are still in the early steps of active master startup. There is only one thread(us)
+      // can access AssignmentManager and create region node, so here we do not need to lock the
+      // region node.
       RegionState regionState = MetaTableLocator.getMetaRegionState(zkw);
       RegionStateNode regionNode =
         regionStates.getOrCreateRegionStateNode(RegionInfoBuilder.FIRST_META_REGIONINFO);