You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Hadrian Zbarcea <hz...@gmail.com> on 2012/02/09 14:50:27 UTC
Re: svn commit: r1242241 - in /camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated:
Key.java KeyValueProtocol.java Value.java
If this is generated code, shouldn't it be generated during compile and
end up somewhere under target/? Then the ASF headers and editing "DO NOT
EDIT DIRECTLY" generated code would not be needed.
Cheers
Hadrian
On 02/09/2012 03:52 AM, ningjiang@apache.org wrote:
> Author: ningjiang
> Date: Thu Feb 9 08:52:46 2012
> New Revision: 1242241
>
> URL: http://svn.apache.org/viewvc?rev=1242241&view=rev
> Log:
> Fixed the CS errors of camel-avro
>
> Modified:
> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java
> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java
> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java
>
> Modified: camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java
> URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java?rev=1242241&r1=1242240&r2=1242241&view=diff
> ==============================================================================
> --- camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java (original)
> +++ camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java Thu Feb 9 08:52:46 2012
> @@ -1,4 +1,21 @@
> /**
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements. See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +// CHECKSTYLE:OFF
> +/**
> * Autogenerated by Avro
> *
> * DO NOT EDIT DIRECTLY
>
> Modified: camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java
> URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java?rev=1242241&r1=1242240&r2=1242241&view=diff
> ==============================================================================
> --- camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java (original)
> +++ camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java Thu Feb 9 08:52:46 2012
> @@ -1,4 +1,21 @@
> /**
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements. See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +// CHECKSTYLE:OFF
> +/**
> * Autogenerated by Avro
> *
> * DO NOT EDIT DIRECTLY
>
> Modified: camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java
> URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java?rev=1242241&r1=1242240&r2=1242241&view=diff
> ==============================================================================
> --- camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java (original)
> +++ camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java Thu Feb 9 08:52:46 2012
> @@ -1,4 +1,21 @@
> /**
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements. See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +// CHECKSTYLE:OFF
> +/**
> * Autogenerated by Avro
> *
> * DO NOT EDIT DIRECTLY
>
>
--
Hadrian Zbarcea
Principal Software Architect
Talend, Inc
http://coders.talend.com/
http://camelbot.blogspot.com/
Re: svn commit: r1242241 - in /camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated:
Key.java KeyValueProtocol.java Value.java
Posted by Willem Jiang <wi...@gmail.com>.
We have the same issue on the protocol buffer databinding.
As they are small pice of codes which are used for testing, we don't
need to generate these codes ever time.
On Thu Feb 9 21:50:27 2012, Hadrian Zbarcea wrote:
> If this is generated code, shouldn't it be generated during compile and
> end up somewhere under target/? Then the ASF headers and editing "DO NOT
> EDIT DIRECTLY" generated code would not be needed.
>
> Cheers
> Hadrian
>
> On 02/09/2012 03:52 AM, ningjiang@apache.org wrote:
>> Author: ningjiang
>> Date: Thu Feb 9 08:52:46 2012
>> New Revision: 1242241
>>
>> URL: http://svn.apache.org/viewvc?rev=1242241&view=rev
>> Log:
>> Fixed the CS errors of camel-avro
>>
>> Modified:
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java
>>
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java
>>
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java
>>
>>
>> Modified:
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java
>>
>> URL:
>> http://svn.apache.org/viewvc/camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java?rev=1242241&r1=1242240&r2=1242241&view=diff
>>
>> ==============================================================================
>>
>> ---
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java
>> (original)
>> +++
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Key.java
>> Thu Feb 9 08:52:46 2012
>> @@ -1,4 +1,21 @@
>> /**
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements. See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License,
>> Version 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License. You may obtain a copy of the License at
>> + *
>> + * http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +// CHECKSTYLE:OFF
>> +/**
>> * Autogenerated by Avro
>> *
>> * DO NOT EDIT DIRECTLY
>>
>> Modified:
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java
>>
>> URL:
>> http://svn.apache.org/viewvc/camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java?rev=1242241&r1=1242240&r2=1242241&view=diff
>>
>> ==============================================================================
>>
>> ---
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java
>> (original)
>> +++
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/KeyValueProtocol.java
>> Thu Feb 9 08:52:46 2012
>> @@ -1,4 +1,21 @@
>> /**
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements. See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License,
>> Version 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License. You may obtain a copy of the License at
>> + *
>> + * http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +// CHECKSTYLE:OFF
>> +/**
>> * Autogenerated by Avro
>> *
>> * DO NOT EDIT DIRECTLY
>>
>> Modified:
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java
>>
>> URL:
>> http://svn.apache.org/viewvc/camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java?rev=1242241&r1=1242240&r2=1242241&view=diff
>>
>> ==============================================================================
>>
>> ---
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java
>> (original)
>> +++
>> camel/trunk/components/camel-avro/src/test/java/org/apache/camel/avro/generated/Value.java
>> Thu Feb 9 08:52:46 2012
>> @@ -1,4 +1,21 @@
>> /**
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements. See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License,
>> Version 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License. You may obtain a copy of the License at
>> + *
>> + * http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +// CHECKSTYLE:OFF
>> +/**
>> * Autogenerated by Avro
>> *
>> * DO NOT EDIT DIRECTLY
>>
>>
>
--
Willem
----------------------------------
FuseSource
Web: http://www.fusesource.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.javaeye.com (Chinese)
Twitter: willemjiang
Weibo: willemjiang